chore: Disable AppStart and NativeFrames integration by default in environments without native support#4897
Merged
Merged
Conversation
…vironments without native support
krystofwoldrich
changed the title
Contributor
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3c99746+dirty | 1215.12 ms | 1222.31 ms | 7.18 ms |
| 472960b+dirty | 1213.96 ms | 1222.58 ms | 8.62 ms |
| f870f2d+dirty | 1227.18 ms | 1232.30 ms | 5.12 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3c99746+dirty | 2.63 MiB | 3.78 MiB | 1.15 MiB |
| 472960b+dirty | 2.63 MiB | 3.79 MiB | 1.15 MiB |
| f870f2d+dirty | 2.63 MiB | 3.79 MiB | 1.15 MiB |
Contributor
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f870f2d+dirty | 398.49 ms | 434.24 ms | 35.75 ms |
| 3c99746+dirty | 400.65 ms | 399.59 ms | -1.06 ms |
| 472960b+dirty | 394.39 ms | 376.18 ms | -18.20 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f870f2d+dirty | 7.15 MiB | 8.34 MiB | 1.18 MiB |
| 3c99746+dirty | 7.15 MiB | 8.34 MiB | 1.18 MiB |
| 472960b+dirty | 7.15 MiB | 8.34 MiB | 1.18 MiB |
Contributor
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3c99746+dirty | 1227.65 ms | 1228.81 ms | 1.16 ms |
| 472960b+dirty | 1243.67 ms | 1233.57 ms | -10.11 ms |
| f870f2d+dirty | 1230.08 ms | 1238.88 ms | 8.80 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3c99746+dirty | 3.19 MiB | 4.35 MiB | 1.16 MiB |
| 472960b+dirty | 3.19 MiB | 4.36 MiB | 1.17 MiB |
| f870f2d+dirty | 3.19 MiB | 4.36 MiB | 1.17 MiB |
Contributor
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3c99746 | 399.51 ms | 429.09 ms | 29.58 ms |
| 472960b | 418.84 ms | 405.38 ms | -13.46 ms |
| f870f2d | 444.67 ms | 449.62 ms | 4.95 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3c99746 | 17.75 MiB | 19.58 MiB | 1.83 MiB |
| 472960b | 17.75 MiB | 19.58 MiB | 1.83 MiB |
| f870f2d | 17.75 MiB | 19.58 MiB | 1.83 MiB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Disabling AppStart and NativeFrames in unsupported environments avoid unexpected warning mentioned in the issues. This leads to better DEX.
I've decided not to log out any information about the fact that the particular integrations are not enabled as we don't do it for the rest either + we already have a generic warning about native features not being available.
💡 Motivation and Context
fixes: #4895
💚 How did you test it?
sample apps, unit tests
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps