Fix: Fix compile error in v7#5134
Merged
Merged
Conversation
noahsmartin
requested review from
alwx,
antonis and
lucas-zimerman
as code owners
Contributor
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 41c41b3+dirty | 1213.76 ms | 1209.60 ms | -4.16 ms |
| b471ffe+dirty | 1233.81 ms | 1235.98 ms | 2.17 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 41c41b3+dirty | 3.19 MiB | 4.44 MiB | 1.25 MiB |
| b471ffe+dirty | 3.19 MiB | 4.44 MiB | 1.25 MiB |
Contributor
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 41c41b3+dirty | 1234.92 ms | 1237.92 ms | 3.00 ms |
| b471ffe+dirty | 1209.71 ms | 1216.72 ms | 7.01 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 41c41b3+dirty | 2.63 MiB | 3.87 MiB | 1.24 MiB |
| b471ffe+dirty | 2.63 MiB | 3.87 MiB | 1.24 MiB |
noahsmartin
force-pushed
the
fixCompileError
branch
from
9469087 to
14ddf52
Compare
Contributor
Android (legacy) Performance metrics 🚀
|
Contributor
Android (new) Performance metrics 🚀
|
noahsmartin
force-pushed
the
fixCompileError
branch
from
14ddf52 to
a862167
Compare
antonis
approved these changes
Sep 3, 2025
Contributor
antonis
left a comment
antonis
left a comment
There was a problem hiding this comment.
Thank you for fixing this @noahsmartin 🙇
LGTM 🚀
antonis
reviewed
Sep 3, 2025
Co-authored-by: Antonis Lilis <antonis.lilis@gmail.com>
antonis
reviewed
Sep 3, 2025
Contributor
|
Thank you for fixing this @noahsmartin. This is now release with https://github.com/getsentry/sentry-react-native/releases/tag/7.0.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest v7 release is causing CI to break in sentry-cocoa, this should fix it
#skip-changelog