DO NOT MERGE: test(ci): Android-only change to validate platform-check action#5874
DO NOT MERGE: test(ci): Android-only change to validate platform-check action#5874
Conversation
The platform-check step that decides whether to skip a build based on detect-changes outputs was duplicated across sample app workflows (sample-application.yml, sample-application-expo.yml) and across the build and test jobs within sample-application.yml. Extract the logic into a composite action at .github/actions/platform-check that takes the platform name, a sample_changed flag, and the needs_ios/needs_android/needs_web outputs as inputs, and returns a single skip output. The action handles the macOS → needs_ios mapping and includes a warning for unknown platforms. Replaces three inline bash scripts with a single reusable action. Closes #5865
Local composite actions (uses: ./.github/actions/...) require the repository to be checked out first. Move the actions/checkout step before platform-check and make it unconditional so the action file is available when GitHub Actions resolves it.
This is a throwaway PR to verify the platform-check composite action correctly skips iOS/macOS builds when only Android native code changes. Expected: iOS and macOS matrix entries show skip=true, Android shows skip=false.
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Features
- Android-only change to validate platform-check action ([#5874](https://github.com/getsentry/sentry-react-native/pull/5874))If none of the above apply, you can opt out of this check by adding |
alwx
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| @@ -0,0 +1 @@ | |||
| // platform-check test: android-only change | |||
There was a problem hiding this comment.
Test file in main source set breaks Android compilation
High Severity
This adds a comment-only RNSentryModule.java to the main source set, but actual RNSentryModule class definitions already exist in both src/oldarch/ and src/newarch/ source sets. Since Gradle combines main with the architecture-specific source set during compilation, this creates a duplicate source file at the same package-relative path, which will cause a compilation error. The PR title explicitly says "DO NOT MERGE" — this is test infrastructure for validating a CI action and replacing critical production code if merged.
Android (legacy) Performance metrics 🚀
|
Android (new) Performance metrics 🚀
|
|
Closing since the test was completed. |
2 participants
Throwaway PR to validate #5873. Expected: iOS/macOS skipped, Android builds.