-
-
Notifications
You must be signed in to change notification settings - Fork 360
DO NOT MERGE: test(ci): iOS-only change to validate platform-check action #5875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| name: 'Platform Check' | ||
| description: 'Decides whether to skip a build/test based on detect-changes outputs' | ||
|
|
||
| inputs: | ||
| platform: | ||
| description: 'Target platform (ios, macos, android, web)' | ||
| required: true | ||
| sample_changed: | ||
| description: 'Whether the sample app itself changed (true/false)' | ||
| required: true | ||
| needs_ios: | ||
| description: 'detect-changes needs_ios output' | ||
| required: false | ||
| default: 'false' | ||
| needs_android: | ||
| description: 'detect-changes needs_android output' | ||
| required: false | ||
| default: 'false' | ||
| needs_web: | ||
| description: 'detect-changes needs_web output' | ||
| required: false | ||
| default: 'false' | ||
|
|
||
| outputs: | ||
| skip: | ||
| description: 'Whether to skip this platform (true/false)' | ||
| value: ${{ steps.check.outputs.skip }} | ||
|
|
||
| runs: | ||
| using: 'composite' | ||
| steps: | ||
| - name: Check if platform is needed | ||
| id: check | ||
| shell: bash | ||
| run: | | ||
| PLATFORM="${{ inputs.platform }}" | ||
| SAMPLE_CHANGED="${{ inputs.sample_changed }}" | ||
|
|
||
| if [[ "$SAMPLE_CHANGED" == "true" ]]; then | ||
| echo "skip=false" >> "$GITHUB_OUTPUT" | ||
| echo "Sample app changed — building/testing $PLATFORM." | ||
| exit 0 | ||
| fi | ||
|
|
||
| # macOS uses the iOS change-detection flag | ||
| case "$PLATFORM" in | ||
| ios|macos) NEEDS="${{ inputs.needs_ios }}" ;; | ||
| android) NEEDS="${{ inputs.needs_android }}" ;; | ||
| web) NEEDS="${{ inputs.needs_web }}" ;; | ||
| *) | ||
| echo "::warning::Unknown platform '$PLATFORM' — not skipping." | ||
| echo "skip=false" >> "$GITHUB_OUTPUT" | ||
| exit 0 | ||
| ;; | ||
| esac | ||
|
|
||
| if [[ "$NEEDS" != "true" ]]; then | ||
| echo "skip=true" >> "$GITHUB_OUTPUT" | ||
| echo "Skipping $PLATFORM — no relevant changes detected." | ||
| else | ||
| echo "skip=false" >> "$GITHUB_OUTPUT" | ||
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| // platform-check test: ios-only change | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test file included in production CocoaPods build
Medium Severity
The new
RNSentryTests.mfile is placed inpackages/core/ios/, which is matched by thesource_filesglob'ios/**/*.{h,m,mm}'inRNSentry.podspec. This means the file will be compiled into every production app that uses this SDK via CocoaPods. While the file currently only contains a comment, it still creates an unnecessary compilation unit in production builds and sets a precedent for test files living in the production source directory. This is flagged because it was mentioned in the rules file under "Debug code shipped" (diagnostics accidentally enabled in production defaults).Triggered by project rule: PR Review Guidelines for Cursor Bot