DO NOT MERGE: test(ci): Sample-only change to validate platform-check action#5876
Closed
DO NOT MERGE: test(ci): Sample-only change to validate platform-check action#5876
Conversation
The platform-check step that decides whether to skip a build based on detect-changes outputs was duplicated across sample app workflows (sample-application.yml, sample-application-expo.yml) and across the build and test jobs within sample-application.yml. Extract the logic into a composite action at .github/actions/platform-check that takes the platform name, a sample_changed flag, and the needs_ios/needs_android/needs_web outputs as inputs, and returns a single skip output. The action handles the macOS → needs_ios mapping and includes a warning for unknown platforms. Replaces three inline bash scripts with a single reusable action. Closes #5865
Local composite actions (uses: ./.github/actions/...) require the repository to be checked out first. Move the actions/checkout step before platform-check and make it unconditional so the action file is available when GitHub Actions resolves it.
This is a throwaway PR to verify the platform-check composite action builds all platforms when only the sample app changes. Expected: All matrix entries show skip=false (sample_changed=true overrides).
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Features
- Sample-only change to validate platform-check action ([#5876](https://github.com/getsentry/sentry-react-native/pull/5876))If none of the above apply, you can opt out of this check by adding |
alwx
changed the title
Collaborator
|
Q: Shouldn't native tests for android/ios run here? EDIT: Sample changes wont trigger Native Test changes |
10 tasks
Collaborator
|
Closing since the test was completed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway PR to validate #5873. Expected: All platforms build (sample_changed=true overrides).