Skip to content

feat(ios): Add attachAllThreads option#5960

Merged
antonis merged 2 commits intomainfrom
antonis/feat/attach-all-threads
Apr 7, 2026
Merged

feat(ios): Add attachAllThreads option#5960
antonis merged 2 commits intomainfrom
antonis/feat/attach-all-threads

Conversation

@antonis
Copy link
Copy Markdown
Contributor

@antonis antonis commented Apr 7, 2026 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Exposes the Cocoa SDK's attachAllThreads option (added in v9.9.0) so React Native users can configure it from JS via Sentry.init(). When enabled, full stack traces for all threads are attached to all captured events on iOS.

The option is automatically forwarded to the native iOS SDK via optionsWithDictionary: — no custom native bridge code is needed.

💡 Motivation and Context

Closes #5959

The Cocoa SDK v9.9.0 introduced attachAllThreads (sentry-cocoa#7764). This PR makes it available to RN users.

💚 How did you test it?

  • Added a test in wrapper.test.ts verifying the option is forwarded to initNativeSdk
  • All existing tests pass

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

@antonis @claude
feat(ios): Add attachAllThreads option
fc1ba86 
Expose the Cocoa SDK's `attachAllThreads` option so it can be
configured from JS via `Sentry.init()`. When enabled, full stack
traces for all threads are attached to captured events on iOS.

Closes #5959

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026 •
edited
Loading

Semver Impact of This PR

⚪ None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

  • feat(ios): Add attachAllThreads option by antonis in #5960
  • fix(core): Lazy-load Metro internal modules to prevent Expo 55 import errors by lucas-zimerman in #5958
  • chore(deps): update Cocoa SDK to v9.9.0 by github-actions in #5956
  • chore(deps): update Maestro to v2.4.0 by github-actions in #5955
  • Feat: Fallback to stacktrace parsing by lucas-zimerman in #5946
  • fix(ci): Bump Node to 22 in size-analysis and testflight workflows by antonis in #5954
  • feat(playground): Open Sentry in desktop browser from Expo apps by antonis in #5947
  • chore(core): Bump sample app to React Native 0.84.1 by antonis in #5941
  • Size analysis for React Native SDK by alwx in #5949
  • chore(deps): bump lodash from 4.17.23 to 4.18.1 by dependabot in #5953
  • chore(deps): bump yauzl to ^3.2.1 by antonis in #5950
  • chore(deps): bump brace-expansion to ^2.0.3 by antonis in #5951
  • chore(deps): bump @xmldom/xmldom to fix XML injection by antonis in #5952

🤖 This preview updates automatically when you update the PR.

@antonis antonis mentioned this pull request Apr 7, 2026
Draft
6 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against c90b30d

antonis
antonis commented Apr 7, 2026
View reviewed changes
@antonis antonis marked this pull request as ready for review April 7, 2026 09:10
@sentry
Copy link
Copy Markdown

sentry bot commented Apr 7, 2026

Sentry Build Distribution

App Name App ID Version Configuration Install Page
Sentry RN io.sentry.reactnative.sample 8.7.0 (82) Release Install Build

lucas-zimerman
lucas-zimerman approved these changes Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lucas-zimerman lucas-zimerman added the ready-to-merge Triggers the full CI test suite label Apr 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 417.30 ms 452.14 ms 34.84 ms
Size 43.75 MiB 48.08 MiB 4.33 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5c1e987+dirty 423.52 ms 471.64 ms 48.12 ms
df5d108+dirty 527.06 ms 603.58 ms 76.52 ms
a50b33d+dirty 500.81 ms 532.11 ms 31.30 ms
4953e94+dirty 442.02 ms 456.52 ms 14.50 ms
3817909+dirty 406.67 ms 416.58 ms 9.91 ms

App size

Revision Plain With Sentry Diff
5c1e987+dirty 43.75 MiB 48.08 MiB 4.33 MiB
df5d108+dirty 43.75 MiB 48.08 MiB 4.33 MiB
a50b33d+dirty 43.75 MiB 48.08 MiB 4.33 MiB
4953e94+dirty 43.75 MiB 48.08 MiB 4.33 MiB
3817909+dirty 43.75 MiB 48.08 MiB 4.33 MiB

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1226.19 ms 1228.04 ms 1.85 ms
Size 3.38 MiB 4.74 MiB 1.35 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
a50b33d+dirty 1197.74 ms 1197.17 ms -0.57 ms
4953e94+dirty 1212.06 ms 1214.83 ms 2.77 ms
df5d108+dirty 1225.90 ms 1220.14 ms -5.76 ms
5c1e987+dirty 1204.30 ms 1222.15 ms 17.85 ms
3817909+dirty 1183.90 ms 1187.50 ms 3.60 ms

App size

Revision Plain With Sentry Diff
a50b33d+dirty 3.38 MiB 4.73 MiB 1.35 MiB
4953e94+dirty 3.38 MiB 4.73 MiB 1.35 MiB
df5d108+dirty 3.38 MiB 4.73 MiB 1.35 MiB
5c1e987+dirty 3.38 MiB 4.73 MiB 1.35 MiB
3817909+dirty 3.38 MiB 4.73 MiB 1.35 MiB

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1190.08 ms 1192.26 ms 2.17 ms
Size 3.38 MiB 4.74 MiB 1.35 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
a50b33d+dirty 1207.11 ms 1212.10 ms 5.00 ms
4953e94+dirty 1217.41 ms 1223.53 ms 6.12 ms
df5d108+dirty 1207.34 ms 1210.50 ms 3.16 ms
5c1e987+dirty 1208.43 ms 1220.72 ms 12.29 ms
3817909+dirty 1210.76 ms 1215.64 ms 4.89 ms

App size

Revision Plain With Sentry Diff
a50b33d+dirty 3.38 MiB 4.73 MiB 1.35 MiB
4953e94+dirty 3.38 MiB 4.73 MiB 1.35 MiB
df5d108+dirty 3.38 MiB 4.73 MiB 1.35 MiB
5c1e987+dirty 3.38 MiB 4.73 MiB 1.35 MiB
3817909+dirty 3.38 MiB 4.73 MiB 1.35 MiB

@antonis antonis merged commit 6cc2aa7 into main Apr 7, 2026
100 of 109 checks passed
@antonis antonis deleted the antonis/feat/attach-all-threads branch April 7, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucas-zimerman lucas-zimerman lucas-zimerman approved these changes

@alwx alwx Awaiting requested review from alwx alwx is a code owner

Assignees

No one assigned

Labels

ready-to-merge Triggers the full CI test suite

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: Expose attachAllThreads option from Cocoa SDK

2 participants

@antonis @lucas-zimerman