fix(ios): honor _experiments.enableUnhandledCPPExceptionsV2 on v8 by antonis · Pull Request #6014 · getsentry/sentry-react-native

antonis · 2026-04-17T09:27:24Z

Note

Stacked on #6012. Review/merge that one first; once it lands, rebase this onto main.

📢 Type of change

Bugfix

📜 Description

Same dead-code drift as the profiling fix in #6012. SentrySDKWrapper.createOptionsWithDictionary parses _experiments.enableUnhandledCPPExceptionsV2 into sentryOptions.experimental.enableUnhandledCPPExceptionsV2 (ios/SentrySDKWrapper.m:105-108), but SentrySDKWrapper has not been on the live init path since #5582 moved init to RNSentryStart. So on iOS this option has been silently ignored in every 8.x release — user Sentry.init({ _experiments: { enableUnhandledCPPExceptionsV2: true } }) does not reach Cocoa.

(Verified Cocoa's SentryOptionsInternal.m does not auto-map _experiments.* from the raw dictionary — only top-level keys like enableLogs. So the gap is real.)

This PR extends the _experiments block introduced in #6012 to also port enableUnhandledCPPExceptionsV2 handling. Adds enabled / disabled / default XCTest coverage on RNSentryStart, mirroring the coverage SentrySDKWrapper already had but on the live path.

💡 Motivation and Context

User-facing: with enableUnhandledCPPExceptionsV2: true set in JS, iOS still falls back to the default handler, so C++ crashes don't get the more reliable __cxa_throw hooking. Same class of silent drop as the profiling regression — same fix pattern.

💚 How did you test it?

Three new XCTest cases on RNSentryStart:
- testStartCreateOptionsWithDictionaryEnableUnhandledCPPExceptionsV2Enabled → asserts actualOptions.experimental.enableUnhandledCPPExceptionsV2 == YES
- …Disabled → asserts == NO
- …Default (no _experiments key) → asserts == NO
Locally: yarn build, yarn circularDepCheck, ./scripts/clang-format.sh lint all clean.

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

`RNSentryStart.createOptionsWithDictionary` (the live iOS init path since v8.0.0) did not read `_experiments.profilingOptions`, silently dropping `profileSessionSampleRate`, `lifecycle`, and `startOnAppStart`. The handling existed in `SentrySDKWrapper`, but that surface hasn't been called from `initNativeSdk` since #5582 — #5611 added the block to the wrong file. Port the handling to `RNSentryStart` and add XCTest coverage for the `startWithOptions` entry point that `initNativeSdk` uses, so this regression can't slip through again. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

- Rewrite CHANGELOG entry to match the descriptive + PR-link format. - Strengthen the two positive profiling tests to invoke the installed callback on a fresh SentryProfileOptions probe and assert that sessionSampleRate, lifecycle, and profileAppStarts land correctly, so a future regression that installs an incomplete callback is caught. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Same dead-code issue as the profiling fix — `SentrySDKWrapper` parses `_experiments.enableUnhandledCPPExceptionsV2`, but `RNSentryStart` (the live init path since v8.0.0) does not. Port the handling into the `_experiments` block just introduced for `profilingOptions`, and add enabled/disabled/default XCTest coverage on `RNSentryStart`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

github-actions · 2026-04-17T09:27:42Z

Semver Impact of This PR

⚪ None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

fix(ios): honor _experiments.enableUnhandledCPPExceptionsV2 on v8 by antonis in #6014

chore(deps): update JavaScript SDK to v10.49.0 by github-actions in #6011
fix(profiling): iOS UI profiling on v8 by antonis in #6012
ci: Integrate Warden for AI-powered PR code review by antonis in #6003
chore(lint): Fixes lint issue on main by antonis in #6013
feat(expo): Warn when prebuilt native projects are missing Sentry config by alwx in #5984

_{🤖 This preview updates automatically when you update the PR.}

…ofiling-options

…ios-cpp-exceptions-v2 # Conflicts: # CHANGELOG.md

…ios-cpp-exceptions-v2

sentry · 2026-04-17T13:02:27Z

📲 Install Builds

Android

🔗 App Name	App ID	Version	Configuration
Sentry RN	io.sentry.reactnative.sample	8.8.0 (83)	Release

⚙️ sentry-react-native Build Distribution Settings

github-actions · 2026-04-17T13:12:42Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1247.35 ms	1233.88 ms	-13.47 ms
Size	3.38 MiB	4.76 MiB	1.38 MiB

github-actions · 2026-04-17T13:30:08Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1217.37 ms	1221.53 ms	4.16 ms
Size	3.38 MiB	4.76 MiB	1.38 MiB

github-actions · 2026-04-20T12:25:50Z

	Fails
🚫	Pull request is not ready for merge, please add the "ready-to-merge" label to the pull request

Generated by 🚫 dangerJS against 7681e4d

…xceptions-v2 # Conflicts: # packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryTests.m # packages/core/ios/RNSentryStart.m

* refactor(ios): remove dead SentrySDKWrapper init surface `SentrySDKWrapper.createOptionsWithDictionary:isSessionReplayEnabled:error:` (and `setupWithDictionary:`, `startWithOptions:`, `enableAutoSessionTracking`, `enableWatchdogTerminationTracking`) became dead when v8 moved init to `RNSentryStart` (#5582 / #4442). The dead methods had a parallel test suite that kept passing, which is exactly how the bugs in #6012 and #6014 shipped: new code was added to `SentrySDKWrapper` because the tests there made it look like the live surface. Delete the dead methods, migrate the still-relevant test coverage to `RNSentryStart`-based tests, drop duplicate tests already pinned on `RNSentryStart`. `SentrySDKWrapper.h` is not in the podspec's `public_header_files`, so no downstream consumers are affected. The kept methods (`configureScope:`, `crash`, `close`, `crashedLastRun`, `debug`, `releaseName`) continue to be used from `RNSentry.mm`. Closes #6015. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(test): drop duplicate testStartBeforeBreadcrumbs… method The migration in the previous commit added a `testStart…KeepsBreadcrumbWhenDevServerUrlIsNotPassed…` method that already existed in the `RNSentryStart Tests` block. Compile failed in CI with "Duplicate declaration of method". The earlier `@interface RNSentryStart Tests` already covers this scenario; the migrated copy is redundant. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(test): use designated initializers for SentryException and SentryMessage Warden flagged the migrated tests using `[SentryException alloc]` and `[SentryMessage alloc]` without `init`. Both classes have `SENTRY_NO_INIT` and require designated initializers (`initWithValue:type:` and `initWithFormatted:`), so the alloc-only pattern is undefined behavior — property assignments happened to work via zero-initialized memory but the test could crash or behave inconsistently and mask real regressions. The pattern was inherited from the original SentrySDKWrapper-based tests this PR migrated; same fix applied across all 12 occurrences. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

antonis and others added 3 commits April 17, 2026 11:08

antonis added 3 commits April 17, 2026 11:32

Merge remote-tracking branch 'origin/main' into antonis/fix-ios-ui-pr…

c4e47bc

…ofiling-options

changelog: simplify profiling fix wording

80e477d

Merge branch 'antonis/fix-ios-ui-profiling-options' into antonis/fix-…

8a9334b

…ios-cpp-exceptions-v2 # Conflicts: # CHANGELOG.md

antonis mentioned this pull request Apr 17, 2026

fix(profiling): iOS UI profiling on v8 #6012

Merged

7 tasks

antonis added 2 commits April 17, 2026 11:50

Merge branch 'main' into antonis/fix-ios-ui-profiling-options

57e86af

Merge branch 'antonis/fix-ios-ui-profiling-options' into antonis/fix-…

fc4dc7d

…ios-cpp-exceptions-v2

This was referenced Apr 17, 2026

Delete abandoned SentrySDKWrapper init surface and migrate tests to RNSentryStart #6015

Closed

Add Android JUnit coverage for configureAndroidProfiling #6016

Closed

antonis marked this pull request as ready for review April 17, 2026 09:58

antonis requested review from alwx and lucas-zimerman as code owners April 17, 2026 09:58

antonis added the ready-to-merge Triggers the full CI test suite label Apr 17, 2026

alwx approved these changes Apr 17, 2026

View reviewed changes

antonis removed the ready-to-merge Triggers the full CI test suite label Apr 20, 2026

Base automatically changed from antonis/fix-ios-ui-profiling-options to main April 23, 2026 11:17

Merge remote-tracking branch 'origin/main' into antonis/fix-ios-cpp-e…

7681e4d

…xceptions-v2 # Conflicts: # packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryTests.m # packages/core/ios/RNSentryStart.m

antonis enabled auto-merge (squash) April 23, 2026 11:30

antonis merged commit 7d6fd3a into main Apr 23, 2026
46 of 61 checks passed

antonis deleted the antonis/fix-ios-cpp-exceptions-v2 branch April 23, 2026 11:31

This was referenced Apr 23, 2026

publish: getsentry/sentry-react-native@8.9.0 getsentry/publish#7919

Closed

publish: getsentry/sentry-react-native@8.9.1 getsentry/publish#7923

Closed

antonis mentioned this pull request Apr 28, 2026

refactor(ios): remove dead SentrySDKWrapper init surface #6059

Merged

7 tasks

antonis mentioned this pull request Apr 28, 2026

test(profiling): pin Android RNSentryStart wiring of _experiments.profilingOptions #6060

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(ios): honor _experiments.enableUnhandledCPPExceptionsV2 on v8#6014

fix(ios): honor _experiments.enableUnhandledCPPExceptionsV2 on v8#6014
antonis merged 9 commits intomainfrom
antonis/fix-ios-cpp-exceptions-v2

antonis commented Apr 17, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 17, 2026 •

edited

Loading

Uh oh!

sentry Bot commented Apr 17, 2026

Uh oh!

github-actions Bot commented Apr 17, 2026

Uh oh!

github-actions Bot commented Apr 17, 2026

Uh oh!

github-actions Bot commented Apr 20, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

antonis commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions Bot commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Semver Impact of This PR

Uh oh!

sentry Bot commented Apr 17, 2026

📲 Install Builds

Android

Uh oh!

github-actions Bot commented Apr 17, 2026

iOS (legacy) Performance metrics 🚀

Uh oh!

github-actions Bot commented Apr 17, 2026

iOS (new) Performance metrics 🚀

Uh oh!

github-actions Bot commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

antonis commented Apr 17, 2026 •

edited

Loading

github-actions Bot commented Apr 17, 2026 •

edited

Loading

github-actions Bot commented Apr 20, 2026 •

edited

Loading