Skip to content

chore(deps-dev): Remove unused uuid devDependency#6041

Merged
antonis merged 2 commits intomainfrom
chore/remove-unused-uuid-devdep
Apr 24, 2026
Merged

chore(deps-dev): Remove unused uuid devDependency#6041
antonis merged 2 commits intomainfrom
chore/remove-unused-uuid-devdep

Conversation

@antonis
Copy link
Copy Markdown
Contributor

@antonis antonis commented Apr 24, 2026

Type of change

  • Refactoring (non-breaking change which improves code quality or performance)

Description

Removes uuid from packages/core/devDependencies. The package is not imported anywhere in the repo — a grep across src/, test/, plugin/, scripts/, and sample apps turns up zero from 'uuid' / require('uuid') statements. All uuid4() calls in the codebase come from @sentry/core.

Git history suggests the dep was left behind during the Yarn v3 / monorepo move (#4057) and has been unused since.

Motivation and Context

Closes the need for #6036 (Dependabot bumping uuid 9.0.1 → 14.0.0). That bump crosses several breaking changes (CJS removal in v12, browser-default exports in v13, Node 20+ requirement in v14) for a dep we don't use. Deleting it is cleaner than merging a major-version bump on dead weight, and silences future Dependabot noise for this package.

So also close/demote https://github.com/getsentry/sentry-react-native/security/dependabot/505 and https://github.com/getsentry/sentry-react-native/security/dependabot/511

How did you test it?

  • yarn install — lockfile updated, uuid removed cleanly
  • yarn build — succeeds
  • yarn test — 210/210 pass
  • yarn circularDepCheck — no circular deps

Checklist

  • I reviewed the code myself
  • I added tests to verify the changes (N/A — removal of unused dep)
  • No new linter warnings

Next steps

Close #6036 with @dependabot ignore this dependency after this merges.

The uuid devDependency is not imported anywhere — all uuid4() calls in
the codebase come from @sentry/core. The dep appears to have been left
behind during the yarn v3 / monorepo move.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@antonis antonis added the ready-to-merge Triggers the full CI test suite label Apr 24, 2026
@sentry
Copy link
Copy Markdown

sentry Bot commented Apr 24, 2026

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
Sentry RN io.sentry.reactnative.sample 8.9.1 (84) Release

⚙️ sentry-react-native Build Distribution Settings

@antonis antonis marked this pull request as ready for review April 24, 2026 10:24
@antonis antonis removed the ready-to-merge Triggers the full CI test suite label Apr 24, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 24, 2026

Fails
🚫 Pull request is not ready for merge, please add the "ready-to-merge" label to the pull request

Generated by 🚫 dangerJS against 137bf80

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c7f55ae. Configure here.

Comment thread packages/core/package.json
@github-actions
Copy link
Copy Markdown
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1231.31 ms 1233.57 ms 2.26 ms
Size 3.38 MiB 4.77 MiB 1.39 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
7ac3378+dirty 1213.37 ms 1218.15 ms 4.78 ms
4b87b12+dirty 1212.90 ms 1222.09 ms 9.19 ms
890d145+dirty 1223.59 ms 1231.37 ms 7.78 ms
0d9949d+dirty 1211.38 ms 1219.67 ms 8.29 ms
04207c4+dirty 1191.27 ms 1189.78 ms -1.48 ms
3ce5254+dirty 1219.93 ms 1221.90 ms 1.96 ms
4953e94+dirty 1212.06 ms 1214.83 ms 2.77 ms
2c735cc+dirty 1229.67 ms 1221.50 ms -8.17 ms
a50b33d+dirty 1197.74 ms 1197.17 ms -0.57 ms
df5d108+dirty 1225.90 ms 1220.14 ms -5.76 ms

App size

Revision Plain With Sentry Diff
7ac3378+dirty 3.38 MiB 4.76 MiB 1.38 MiB
4b87b12+dirty 3.38 MiB 4.77 MiB 1.39 MiB
890d145+dirty 3.38 MiB 4.77 MiB 1.38 MiB
0d9949d+dirty 3.38 MiB 4.76 MiB 1.38 MiB
04207c4+dirty 3.38 MiB 4.76 MiB 1.38 MiB
3ce5254+dirty 3.38 MiB 4.76 MiB 1.38 MiB
4953e94+dirty 3.38 MiB 4.73 MiB 1.35 MiB
2c735cc+dirty 3.38 MiB 4.74 MiB 1.35 MiB
a50b33d+dirty 3.38 MiB 4.73 MiB 1.35 MiB
df5d108+dirty 3.38 MiB 4.73 MiB 1.35 MiB

Companion to the uuid removal — @types/uuid provided types for a
package no longer in the project. Flagged by Cursor Bugbot review.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@antonis antonis merged commit c407368 into main Apr 24, 2026
56 of 62 checks passed
@antonis antonis deleted the chore/remove-unused-uuid-devdep branch April 24, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants