Skip to content

fix(ci): Install both tarballs in validate job to satisfy cross-dep #6052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonis merged 1 commit into from
Apr 27, 2026
Merged

fix(ci): Install both tarballs in validate job to satisfy cross-dep #6052

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/workflows/buildandtest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,11 +210,18 @@ jobs:
- name: Install tarball into fresh project
run: |
set -e
TARBALL=$(find "$PWD/artifacts" -name 'sentry-react-native-*.tgz' -print -quit)
CORE_TARBALL=$(find "$PWD/artifacts" -name 'sentry-react-native-*.tgz' -print -quit)
EXPO_TARBALL=$(find "$PWD/artifacts" -name 'sentry-expo-upload-sourcemaps-*.tgz' -print -quit)
[ -n "$CORE_TARBALL" ] || { echo "::error::core tarball not found"; exit 1; }
[ -n "$EXPO_TARBALL" ] || { echo "::error::expo-upload-sourcemaps tarball not found"; exit 1; }
mkdir -p /tmp/install-test
cd /tmp/install-test
npm init -y >/dev/null
npm install --no-save "$TARBALL"
# Install both local tarballs together so the @sentry/expo-upload-sourcemaps
# cross-dep is satisfied locally. On a release branch the bumped version
# is not on the npm registry yet (workspace:* resolves to the version
# we are about to publish), and a registry fetch would fail with ETARGET.
npm install --no-save "$EXPO_TARBALL" "$CORE_TARBALL"
# workspace:* spec must have been resolved by yarn pack (#6037 regression)
if grep -q 'workspace:' node_modules/@sentry/react-native/package.json; then
echo "::error::published package.json still contains unresolved workspace: spec"
Expand Down
Loading