Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,14 @@
> make sure you follow our [migration guide](https://docs.sentry.io/platforms/react-native/migration/) first.
<!-- prettier-ignore-end -->

## Unreleased

### Dependencies

- Bump Cocoa SDK from v9.19.1 to v9.20.0 ([#6409](https://github.com/getsentry/sentry-react-native/pull/6409))
- [changelog](https://github.com/getsentry/sentry-cocoa/blob/main/CHANGELOG.md#9200)
- [diff](https://github.com/getsentry/sentry-cocoa/compare/9.19.1...9.20.0)

## 8.17.2

### Fixes
Expand Down
2 changes: 1 addition & 1 deletion packages/core/RNSentry.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ Pod::Spec.new do |s|
'DEFINES_MODULE' => 'YES'
}

sentry_cocoa_version = '9.19.1'
sentry_cocoa_version = '9.20.0'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The podspec references Sentry Cocoa SDK version 9.20.0, which is not available on CocoaPods. This will cause pod install to fail for default installations.
Severity: CRITICAL

Suggested Fix

Since version 9.20.0 is not on CocoaPods, either revert the version update in the podspec to a version that is available on CocoaPods, or update the logic to make SPM the default. Alternatively, update the CI and documentation to enforce setting SENTRY_USE_SPM=1 for this and future versions.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: packages/core/RNSentry.podspec#L57

Potential issue: The pull request updates the Sentry Cocoa SDK dependency to version
9.20.0 in `RNSentry.podspec`. However, this version was not published to CocoaPods, only
to Swift Package Manager (SPM). The podspec defaults to using CocoaPods unless the
`SENTRY_USE_SPM` environment variable is explicitly set to '1'. Consequently, any user
or CI/CD process (like the `native-tests.yml` workflow) running `pod install` without
this environment variable will encounter a build failure because the specified
dependency version cannot be resolved from the CocoaPods repository.

Did we get this right? 👍 / 👎 to inform future reviews.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the Blocked label since this is blocking till the xcframeworks work replacing the cocoapod dependency land.
Also added the ready-to-merge label to see how the failure reflects on the CI checks.


# Opt-in to consuming sentry-cocoa via Swift Package Manager.
# When `SENTRY_USE_SPM=1` is set, RNSentry pulls `Sentry` from the
Expand Down
Loading