Skip to content

Commit 84e50c5

Browse files
authored
fix(specs): stop sidekiq-scheduler after each test (#2897)
Otherwise this may happen: ``` 1) Sentry::Sidekiq::Cron::Job sidekiq-cron adds job to sidekiq within transaction Failure/Error: expect(::Sidekiq::Queue.new.size).to eq(2) expected: 2 got: 5 (compared using ==) # ./spec/sentry/sidekiq/cron/job_spec.rb:124:in `block in <main>' Finished in 6.23 seconds (files took 4.01 seconds to load) 75 examples, 1 failure, 2 pending Failed examples: rspec ./spec/sentry/sidekiq/cron/job_spec.rb:118 # Sentry::Sidekiq::Cron::Job sidekiq-cron adds job to sidekiq within transaction ```
1 parent c081d11 commit 84e50c5

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

sentry-sidekiq/spec/sentry/sidekiq-scheduler/scheduler_spec.rb

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,12 @@
1919
scheduler_config = SidekiqScheduler::Config.new(sidekiq_config: sidekiq_config(config_options))
2020

2121
# Making and starting a Manager instance will load the jobs
22-
schedule_manager = SidekiqScheduler::Manager.new(scheduler_config)
23-
schedule_manager.start
22+
@schedule_manager = SidekiqScheduler::Manager.new(scheduler_config)
23+
@schedule_manager.start
24+
end
25+
26+
after do
27+
@schedule_manager&.stop
2428
end
2529

2630
it 'patches class' do

0 commit comments

Comments
 (0)