WIP

Author: solnic

.github/workflows/e2e_tests.yml

@@ -43,6 +43,18 @@ jobs:
           source .env
           docker compose --profile e2e up -d sentry-svelte-mini
 
+      - name: Wait for services to be healthy
+        run: |
+          echo "Waiting for Rails mini app to be ready..."
+          timeout 60 bash -c 'until curl -s http://localhost:5000/health | grep -q "ok"; do echo "Waiting for Rails app..."; sleep 2; done'
+          echo "✅ Rails mini app is ready"
+
+          echo "Waiting for Svelte mini app to be ready..."
+          timeout 60 bash -c 'until curl -s http://localhost:5001/health | grep -q "ok"; do echo "Waiting for Svelte app..."; sleep 2; done'
+          echo "✅ Svelte mini app is ready"
+
+          echo "All services are healthy!"
+
       - name: Run e2e tests
         run: |
           cd .devcontainer

Rakefile

@@ -32,11 +32,22 @@ namespace :spec do
 
       # Wait for services to be ready
       puts "Waiting for services to be ready..."
-      unless system("timeout 60 bash -c 'until curl -s http://localhost:5000/trace_headers >/dev/null && curl -s http://localhost:5001 >/dev/null; do sleep 2; done'")
-        puts "Services failed to become ready"
+      puts "Checking Rails mini app health..."
+      unless system("timeout 60 bash -c 'until curl -s http://localhost:5000/health | grep -q \"ok\"; do echo \"Waiting for Rails app...\"; sleep 2; done'")
+        puts "Rails mini app failed to become ready"
         Dir.chdir('.devcontainer') { system("docker-compose --profile e2e down") }
         exit(1)
       end
+      puts "✅ Rails mini app is ready"
+
+      puts "Checking Svelte mini app health..."
+      unless system("timeout 60 bash -c 'until curl -s http://localhost:5001/health | grep -q \"ok\"; do echo \"Waiting for Svelte app...\"; sleep 2; done'")
+        puts "Svelte mini app failed to become ready"
+        Dir.chdir('.devcontainer') { system("docker-compose --profile e2e down") }
+        exit(1)
+      end
+      puts "✅ Svelte mini app is ready"
+      puts "All services are healthy!"
 
       # Run tests in sentry container with proper environment variables
       Dir.chdir('.devcontainer') do

sentry-ruby/lib/sentry/transport/debug_transport.rb

@@ -62,9 +62,37 @@ def initialize_backend(configuration)
     def initialize_log_file(configuration)
       log_file = Pathname(configuration.sdk_debug_transport_log_file || DEFAULT_LOG_FILE_PATH)
 
-      FileUtils.mkdir_p(log_file.dirname) unless log_file.dirname.exist?
+      unless log_file.dirname.exist?
+        begin
+          FileUtils.mkdir_p(log_file.dirname)
+        rescue Errno::EACCES => e
+          raise "Cannot create log directory #{log_file.dirname}: #{e.message}"
+        end
+      end
+
+      check_log_file_permissions(log_file)
 
       log_file
     end
+
+    def check_log_file_permissions(log_file)
+      if log_file.exist?
+        unless log_file.writable?
+          raise "Cannot write to log file #{log_file}: Permission denied"
+        end
+      else
+        unless log_file.dirname.writable?
+          raise "Cannot write to log directory #{log_file.dirname}: Permission denied"
+        end
+
+        begin
+          File.open(log_file, "a") { |f| f.write("") }
+        rescue Errno::EACCES => e
+          raise "Cannot write to log file #{log_file}: #{e.message}"
+        rescue => e
+          raise "Failed to initialize log file #{log_file}: #{e.message}"
+        end
+      end
+    end
   end
 end

spec/apps/rails-mini/app.rb

@@ -27,6 +27,32 @@ class RailsMiniApp < Rails::Application
   config.api_only = true
   config.force_ssl = false
 
+  # Validate DSN before starting
+  initializer :validate_dsn, before: :configure_sentry do
+    dsn_string = ENV["SENTRY_DSN"]
+
+    if dsn_string.nil? || dsn_string.empty?
+      puts "ERROR: SENTRY_DSN environment variable is required but not set"
+      exit(1)
+    end
+
+    begin
+      dsn = Sentry::DSN.new(dsn_string)
+      unless dsn.valid?
+        puts "ERROR: Invalid SENTRY_DSN: #{dsn_string}"
+        puts "DSN must include host, path, public_key, and project_id"
+        exit(1)
+      end
+      puts "✅ SENTRY_DSN validation passed: #{dsn_string}"
+    rescue URI::InvalidURIError => e
+      puts "ERROR: Invalid SENTRY_DSN format: #{e.message}"
+      exit(1)
+    rescue => e
+      puts "ERROR: Failed to parse SENTRY_DSN: #{e.message}"
+      exit(1)
+    end
+  end
+
   # Configure Sentry
   initializer :configure_sentry do
     Sentry.init do |config|
@@ -40,7 +66,7 @@ class RailsMiniApp < Rails::Application
       config.release = "sentry-ruby-rails-mini-#{Time.now.utc}"
 
       config.transport.transport_class = Sentry::DebugTransport
-      config.sdk_debug_transport_log_file = "/workspace/sentry/log/sentry_debug_events.log"
+      config.sdk_debug_transport_log_file = File.join(Dir.pwd, "log", "sentry_debug_events.log")
       config.background_worker_threads = 0
     end
   end
@@ -66,30 +92,41 @@ def set_cors_headers
 class EventsController < ActionController::Base
   before_action :set_cors_headers
 
-
+  def health
+    render json: {
+      status: "ok",
+      timestamp: Time.now.utc.iso8601,
+      sentry_initialized: Sentry.initialized?,
+      log_file_writable: check_log_file_writable
+    }
+  end
 
   def trace_headers
-    # Return current trace propagation headers
     headers = Sentry.get_trace_propagation_headers || {}
     render json: { headers: headers }
   end
 
-
-
   private
 
+  def check_log_file_writable
+    log_file_path = File.join(Dir.pwd, "log", "sentry_debug_events.log")
+    File.writable?(File.dirname(log_file_path)) &&
+      (!File.exist?(log_file_path) || File.writable?(log_file_path))
+  rescue
+    false
+  end
+
   def set_cors_headers
     response.headers['Access-Control-Allow-Origin'] = '*'
     response.headers['Access-Control-Allow-Methods'] = 'GET, POST, PUT, DELETE, OPTIONS'
     response.headers['Access-Control-Allow-Headers'] = 'Content-Type, Authorization, sentry-trace, baggage'
   end
 end
 
-# Initialize the Rails app first
 RailsMiniApp.initialize!
 
-# Configure routes after initialization
 RailsMiniApp.routes.draw do
+  get '/health', to: 'events#health'
   get '/error', to: 'error#error'
   get '/trace_headers', to: 'events#trace_headers'
 

spec/apps/svelte-mini/vite.config.js

@@ -2,7 +2,27 @@ import { defineConfig } from 'vite'
 import { svelte } from '@sveltejs/vite-plugin-svelte'
 
 export default defineConfig({
-  plugins: [svelte()],
+  plugins: [
+    svelte(),
+    {
+      name: 'health-check',
+      configureServer(server) {
+        server.middlewares.use('/health', (req, res, next) => {
+          if (req.method === 'GET') {
+            res.setHeader('Content-Type', 'application/json')
+            res.setHeader('Access-Control-Allow-Origin', '*')
+            res.end(JSON.stringify({
+              status: 'ok',
+              timestamp: new Date().toISOString(),
+              service: 'svelte-mini'
+            }))
+          } else {
+            next()
+          }
+        })
+      }
+    }
+  ],
   server: {
     port: 5001,
     host: '0.0.0.0',