[devcontainer] fix git command in run script#2710
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- [devcontainer] fix git command in run script ([#2710](https://github.com/getsentry/sentry-ruby/pull/2710))If none of the above apply, you can opt out of this check by adding |
| git config --global safe.directory /workspace/sentry | ||
| git config --global safe.directory /workspace/sentry/vendor/gems/* | ||
| git config --global --replace-all safe.directory /workspace/sentry | ||
| git config --global --replace-all safe.directory /workspace/sentry/vendor/gems/* |
There was a problem hiding this comment.
Bug: Git Config Overwrites Safe Directories
The --replace-all flag on the second git config command causes it to overwrite the first safe.directory setting. This results in only /workspace/sentry/vendor/gems/* being configured as safe, while /workspace/sentry is unintentionally removed, which could lead to git operations failing.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2710 +/- ##
=======================================
Coverage 97.31% 97.31%
=======================================
Files 144 144
Lines 5652 5652
=======================================
Hits 5500 5500
Misses 152 152
🚀 New features to boost your workflow:
|
Otherwise this command would crash with recent git.