fix: pass failed request codes down to cocoa (#2619)

Author: bitsandfoxes

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 ### Fixes
 
+- When targeting iOS or macOS, the SDK now correctly passes on the `CaptureFailedRequests` flag and set status code ranged ([#2619](https://github.com/getsentry/sentry-unity/pull/2619))
 - The SDK now correctly resolves the storage path on Xbox during initialization, enabling offline caching and native crash capturing without user setup out of the box. ([#2617](https://github.com/getsentry/sentry-unity/pull/2617))
 
 ### Features

package-dev/Plugins/iOS/SentryNativeBridge.m

@@ -66,6 +66,17 @@ void SentryNativeBridgeOptionsSetInt(const void *options, const char *name, int3
     dictOptions[[NSString stringWithUTF8String:name]] = [NSNumber numberWithInt:value];
 }
 
+void SentryNativeBridgeOptionsAddFailedRequestStatusCodeRange(const void *options, int32_t min, int32_t max)
+{
+    NSMutableDictionary *dictOptions = (__bridge NSMutableDictionary *)options;
+    NSMutableArray *ranges = dictOptions[@"failedRequestStatusCodes"];
+    if (!ranges) {
+        ranges = [[NSMutableArray alloc] init];
+        dictOptions[@"failedRequestStatusCodes"] = ranges;
+    }
+    [ranges addObject:[[SentryHttpStatusCodeRange alloc] initWithMin:min max:max]];
+}
+
 int SentryNativeBridgeStartWithOptions(const void *options)
 {
     NSMutableDictionary *dictOptions = (__bridge_transfer NSMutableDictionary *)options;

package-dev/Plugins/iOS/SentryNativeBridgeNoOp.m

@@ -6,6 +6,7 @@
 void *_Nullable SentryNativeBridgeOptionsNew() { return nil; }
 void SentryNativeBridgeOptionsSetString(void *options, const char *name, const char *value) { }
 void SentryNativeBridgeOptionsSetInt(void *options, const char *name, int32_t value) { }
+void SentryNativeBridgeOptionsAddFailedRequestStatusCodeRange(void *options, int32_t min, int32_t max) { }
 int SentryNativeBridgeStartWithOptions(void *options) { return 0; }
 
 void SentryNativeBridgeSetSdkName() { }

package-dev/Plugins/macOS/SentryNativeBridge.m

@@ -1,5 +1,6 @@
 #import <Foundation/Foundation.h>
 #include <dlfcn.h>
+#include <objc/message.h>
 
 static NSDateFormatter *_Nullable sentry_cachedISO8601Formatter(void) {
     static NSDateFormatter *formatter = nil;
@@ -45,6 +46,7 @@
 static Class SentryId;
 static Class SentrySpanId;
 static Class PrivateSentrySDKOnly;
+static Class SentryHttpStatusCodeRange;
 
 #define LOAD_CLASS_OR_BREAK(name)                                                                  \
     name = (__bridge Class)dlsym(dylib, "OBJC_CLASS_$_" #name);                                    \
@@ -87,6 +89,7 @@ int SentryNativeBridgeLoadLibrary()
             LOAD_CLASS_OR_BREAK(SentryId)
             LOAD_CLASS_OR_BREAK(SentrySpanId)
             LOAD_CLASS_OR_BREAK(PrivateSentrySDKOnly)
+            LOAD_CLASS_OR_BREAK(SentryHttpStatusCodeRange)
 
             // everything above passed - mark as successfully loaded
             loadStatus = 1;
@@ -118,6 +121,23 @@ void SentryNativeBridgeOptionsSetInt(const void *options, const char *name, int3
     dictOptions[[NSString stringWithUTF8String:name]] = [NSNumber numberWithInt:value];
 }
 
+void SentryNativeBridgeOptionsAddFailedRequestStatusCodeRange(const void *options, int32_t min, int32_t max)
+{
+    NSMutableDictionary *dictOptions = (__bridge NSMutableDictionary *)options;
+    NSMutableArray *ranges = dictOptions[@"failedRequestStatusCodes"];
+    if (!ranges) {
+        ranges = [[NSMutableArray alloc] init];
+        dictOptions[@"failedRequestStatusCodes"] = ranges;
+    }
+    id instance = [SentryHttpStatusCodeRange alloc];
+    // initWithMin:max: takes NSInteger args - use objc_msgSend directly
+    id range = ((id (*)(id, SEL, NSInteger, NSInteger))objc_msgSend)(
+        instance, @selector(initWithMin:max:), (NSInteger)min, (NSInteger)max);
+    if (range) {
+        [ranges addObject:range];
+    }
+}
+
 int SentryNativeBridgeStartWithOptions(const void *options)
 {
     NSMutableDictionary *dictOptions = (__bridge_transfer NSMutableDictionary *)options;

src/Sentry.Unity.iOS/SentryCocoaBridgeProxy.cs

@@ -69,6 +69,15 @@ public static bool Init(SentryUnityOptions options)
         Logger?.LogDebug("Setting EnableWatchdogTerminationTracking: {0}", options.IosWatchdogTerminationIntegrationEnabled);
         OptionsSetInt(cOptions, "enableWatchdogTerminationTracking", options.IosWatchdogTerminationIntegrationEnabled ? 1 : 0);
 
+        Logger?.LogDebug("Setting CaptureFailedRequests: {0}", options.CaptureFailedRequests);
+        OptionsSetInt(cOptions, "enableCaptureFailedRequests", options.CaptureFailedRequests ? 1 : 0);
+
+        foreach (var range in options.FailedRequestStatusCodes)
+        {
+            Logger?.LogDebug("Adding FailedRequestStatusCodeRange: {0}-{1}", range.Start, range.End);
+            OptionsAddFailedRequestStatusCodeRange(cOptions, range.Start, range.End);
+        }
+
         var result = StartWithOptions(cOptions);
         return result is 1;
     }
@@ -88,6 +97,9 @@ public static bool Init(SentryUnityOptions options)
     [DllImport("__Internal", EntryPoint = "SentryNativeBridgeOptionsSetInt")]
     private static extern void OptionsSetInt(IntPtr options, string name, int value);
 
+    [DllImport("__Internal", EntryPoint = "SentryNativeBridgeOptionsAddFailedRequestStatusCodeRange")]
+    private static extern void OptionsAddFailedRequestStatusCodeRange(IntPtr options, int min, int max);
+
     [DllImport("__Internal", EntryPoint = "SentryNativeBridgeStartWithOptions")]
     private static extern int StartWithOptions(IntPtr options);