chore(preprod): Filter out mobile builds if any related size status is NOT_RAN (#107885)

Close
https://linear.app/getsentry/issue/EME-801/hide-builds-with-not-ran-size-analysis-from-size-table

Author: NicoHinderling

src/sentry/preprod/artifact_search.py

@@ -15,7 +15,11 @@
 from sentry.db.models.fields.bounded import I64_MAX
 from sentry.exceptions import InvalidSearchQuery
 from sentry.models.organization import Organization
-from sentry.preprod.models import PreprodArtifact, PreprodArtifactQuerySet
+from sentry.preprod.models import (
+    PreprodArtifact,
+    PreprodArtifactQuerySet,
+    PreprodArtifactSizeMetrics,
+)
 
 search_config = SearchConfig.create_from(
     SearchConfig(),
@@ -63,6 +67,7 @@
         "installable",
         "is",
         "platform_name",
+        "size_state",
     },
     # Enable boolean operators
     # allow_boolean=True,
@@ -96,9 +101,24 @@ def get_field_type(key: str) -> str | None:
     "git_head_ref": "commit_comparison__head_ref",
     "git_head_sha": "commit_comparison__head_sha",
     "git_pr_number": "commit_comparison__pr_number",
+    "size_state": "preprodartifactsizemetrics__state",
+}
+
+SIZE_STATE_VALUES: dict[str, int] = {
+    member.name.lower(): member.value for member in PreprodArtifactSizeMetrics.SizeAnalysisState
 }
 
 
+def _translate_size_state(value: object) -> int:
+    raw = str(value).lower()
+    if raw not in SIZE_STATE_VALUES:
+        raise InvalidSearchQuery(
+            f"Invalid size_state value: {value}. "
+            f"Valid values: {', '.join(sorted(SIZE_STATE_VALUES))}"
+        )
+    return SIZE_STATE_VALUES[raw]
+
+
 def queryset_for_query(
     query: str,
     organization: Organization,
@@ -224,6 +244,16 @@ def apply_filters(
 
         db_field = FIELD_MAPPINGS.get(name, name)
 
+        if name == "size_state":
+            values = token.value.value if token.is_in_filter else [token.value.value]
+            q = Q(**{f"{db_field}__in": [_translate_size_state(v) for v in values]})
+            if token.is_negation:
+                queryset = queryset.exclude(q)
+            else:
+                queryset = queryset.filter(q)
+            queryset = queryset.distinct()
+            continue
+
         # We don't have to handle boolean operators or parens here
         # since allow_boolean is not set in SearchConfig.
         if token.is_in_filter:

tests/sentry/preprod/api/endpoints/test_builds.py

@@ -4,6 +4,7 @@
 from django.urls import reverse
 from django.utils.functional import cached_property
 
+from sentry.preprod.models import PreprodArtifactSizeMetrics
 from sentry.testutils.cases import APITestCase
 from sentry.testutils.helpers.datetime import before_now
 from sentry.testutils.helpers.features import with_feature
@@ -845,6 +846,57 @@ def test_free_text_search_with_structured_filter(self) -> None:
         assert len(data) == 1
         assert data[0]["app_info"]["app_id"] == "com.example.android"
 
+    @with_feature("organizations:preprod-frontend-routes")
+    def test_size_state_filter(self) -> None:
+        artifact_not_ran = self.create_preprod_artifact(app_id="not_ran.app")
+        self.create_preprod_artifact_size_metrics(
+            artifact_not_ran,
+            state=PreprodArtifactSizeMetrics.SizeAnalysisState.NOT_RAN,
+            error_code=PreprodArtifactSizeMetrics.ErrorCode.SKIPPED,
+            error_message="Size analysis not supported",
+        )
+        artifact_completed = self.create_preprod_artifact(app_id="completed.app")
+        self.create_preprod_artifact_size_metrics(
+            artifact_completed, state=PreprodArtifactSizeMetrics.SizeAnalysisState.COMPLETED
+        )
+        self.create_preprod_artifact(app_id="no_metrics.app")
+
+        response = self._request({})
+        self._assert_is_successful(response)
+        assert len(response.json()) == 3
+
+        response = self._request({"query": "size_state:completed"})
+        self._assert_is_successful(response)
+        assert len(response.json()) == 1
+        assert response.json()[0]["app_info"]["app_id"] == "completed.app"
+
+        response = self._request({"query": "!size_state:not_ran"})
+        self._assert_is_successful(response)
+        assert len(response.json()) == 2
+
+    @with_feature("organizations:preprod-frontend-routes")
+    def test_size_state_filter_mixed_metrics(self) -> None:
+        artifact = self.create_preprod_artifact(app_id="mixed.app")
+        self.create_preprod_artifact_size_metrics(
+            artifact, state=PreprodArtifactSizeMetrics.SizeAnalysisState.COMPLETED
+        )
+        self.create_preprod_artifact_size_metrics(
+            artifact,
+            state=PreprodArtifactSizeMetrics.SizeAnalysisState.NOT_RAN,
+            metrics_type=PreprodArtifactSizeMetrics.MetricsArtifactType.WATCH_ARTIFACT,
+            error_code=PreprodArtifactSizeMetrics.ErrorCode.SKIPPED,
+            error_message="Size analysis not supported",
+        )
+        response = self._request({"query": "!size_state:not_ran"})
+        self._assert_is_successful(response)
+        assert len(response.json()) == 0
+
+    @with_feature("organizations:preprod-frontend-routes")
+    def test_size_state_invalid_values(self) -> None:
+        self.create_preprod_artifact(app_id="test.app")
+        assert self._request({"query": "size_state:bogus"}).status_code == 400
+        assert self._request({"query": "size_state:[bogus, completed]"}).status_code == 400
+
 
 class QuerysetForQueryTest(APITestCase):
     """Tests for the queryset_for_query, artifact_in_queryset, and artifact_matches_query functions."""

tests/sentry/preprod/api/endpoints/test_organization_preprod_list_builds.py

@@ -7,7 +7,7 @@
 
 from sentry import analytics
 from sentry.preprod.analytics import PreprodArtifactApiListBuildsEvent
-from sentry.preprod.models import PreprodArtifact
+from sentry.preprod.models import PreprodArtifact, PreprodArtifactSizeMetrics
 from sentry.testutils.cases import APITestCase
 
 
@@ -742,3 +742,21 @@ def test_list_builds_filter_project_and_other_criteria(self) -> None:
         builds = response.json()["builds"]
         assert len(builds) == 1
         assert builds[0]["app_info"]["app_id"] == "com.example.app4"
+
+    def test_list_builds_does_not_filter_by_size_state(self) -> None:
+        self.create_preprod_artifact_size_metrics(
+            self.artifact1,
+            state=PreprodArtifactSizeMetrics.SizeAnalysisState.NOT_RAN,
+            error_code=PreprodArtifactSizeMetrics.ErrorCode.SKIPPED,
+            error_message="Size analysis was not requested",
+        )
+        response = self.client.get(
+            f"{self._get_url()}?project={self.project.id}&project={self.project2.id}",
+            format="json",
+            HTTP_AUTHORIZATION=f"Bearer {self.api_token.token}",
+        )
+        assert response.status_code == 200
+        builds = response.json()["builds"]
+        assert len(builds) == 4
+        app_ids = {b["app_info"]["app_id"] for b in builds}
+        assert "com.example.app" in app_ids