chore(metrics): remove DDM references (#68898)

Author: obostjancic

static/app/components/assistant/getGuidesContent.tsx

@@ -174,19 +174,6 @@ export default function getGuidesContent(orgSlug: string | null): GuidesContent
         },
       ],
     },
-    {
-      guide: 'ddm_view',
-      requiredTargets: ['create_scratchpad'],
-      steps: [
-        {
-          title: t('Save your charts'),
-          target: 'create_scratchpad',
-          description: t(
-            `Scratchpads are stored locally on your device. If you want to share them, simply send the URL to your teammates.`
-          ),
-        },
-      ],
-    },
   ];
 }
 

static/app/types/hooks.tsx

@@ -93,7 +93,7 @@ type DisabledMemberTooltipProps = {children: React.ReactNode};
 
 type DashboardHeadersProps = {organization: Organization};
 
-type DDMMetricsSamplesListProps = {children: React.ReactNode; organization: Organization};
+type MetricsSamplesListProps = {children: React.ReactNode; organization: Organization};
 
 type ReplayFeedbackButton = {children: React.ReactNode};
 type ReplayListPageHeaderProps = {children?: React.ReactNode};
@@ -188,7 +188,7 @@ export type ComponentHooks = {
   'component:dashboards-header': () => React.ComponentType<DashboardHeadersProps>;
   'component:data-consent-banner': () => React.ComponentType<{source: string}> | null;
   'component:data-consent-priority-learn-more': () => React.ComponentType<{}> | null;
-  'component:ddm-metrics-samples-list': () => React.ComponentType<DDMMetricsSamplesListProps>;
+  'component:ddm-metrics-samples-list': () => React.ComponentType<MetricsSamplesListProps>;
   'component:disabled-app-store-connect-multiple': () => React.ComponentType<DisabledAppStoreConnectMultiple>;
   'component:disabled-custom-symbol-sources': () => React.ComponentType<DisabledCustomSymbolSources>;
   'component:disabled-member': () => React.ComponentType<DisabledMemberViewProps>;

static/app/types/metrics.tsx

@@ -43,7 +43,7 @@ export interface MetricsApiRequestQuery extends MetricsApiRequestMetric {
   statsPeriod?: string;
 }
 
-export type MetricsDataIntervalLadder = 'ddm' | 'bar' | 'dashboard';
+export type MetricsDataIntervalLadder = 'metrics' | 'bar' | 'dashboard';
 
 export type MetricsApiResponse = {
   end: string;

static/app/utils/metrics/dashboard.tsx

@@ -5,11 +5,7 @@ import {defined} from 'sentry/utils';
 import {MRIToField} from 'sentry/utils/metrics/mri';
 import type {MetricDisplayType, MetricsQuery} from 'sentry/utils/metrics/types';
 import type {Widget, WidgetQuery} from 'sentry/views/dashboards/types';
-import {
-  DashboardWidgetSource,
-  DisplayType,
-  WidgetType,
-} from 'sentry/views/dashboards/types';
+import {DisplayType, WidgetType} from 'sentry/views/dashboards/types';
 
 interface QueryParams extends MetricsQuery {
   id?: number;
@@ -90,7 +86,6 @@ export function getWidgetAsQueryParams(
   const {projects} = selection;
 
   return {
-    source: DashboardWidgetSource.DDM,
     start,
     end,
     statsPeriod: period,

static/app/utils/metrics/index.spec.tsx

@@ -4,8 +4,8 @@ import type {MetricsOperation} from 'sentry/types';
 import {
   getAbsoluteDateTimeRange,
   getDateTimeParams,
-  getDDMInterval,
   getFormattedMQL,
+  getMetricsInterval,
   isFormattedMQL,
 } from 'sentry/utils/metrics';
 
@@ -14,7 +14,7 @@ describe('getDDMInterval', () => {
     const dateTimeObj = {start: '2023-01-01', end: '2023-01-31'};
     const useCase = 'sessions';
 
-    const result = getDDMInterval(dateTimeObj, useCase);
+    const result = getMetricsInterval(dateTimeObj, useCase);
 
     expect(result).toBe('2h');
   });
@@ -26,7 +26,7 @@ describe('getDDMInterval', () => {
     };
     const useCase = 'custom';
 
-    const result = getDDMInterval(dateTimeObj, useCase);
+    const result = getMetricsInterval(dateTimeObj, useCase);
 
     expect(result).toBe('10s');
   });
@@ -35,7 +35,7 @@ describe('getDDMInterval', () => {
     const dateTimeObj = {start: '2023-01-01', end: '2023-01-01T01:05:00.000Z'};
     const useCase = 'sessions';
 
-    const result = getDDMInterval(dateTimeObj, useCase);
+    const result = getMetricsInterval(dateTimeObj, useCase);
 
     expect(result).toBe('1m');
   });

static/app/utils/metrics/index.tsx

@@ -99,7 +99,7 @@ export function getMetricsUrl(
 }
 
 const intervalLadders: Record<MetricsDataIntervalLadder, GranularityLadder> = {
-  ddm: new GranularityLadder([
+  metrics: new GranularityLadder([
     [SIXTY_DAYS, '1d'],
     [THIRTY_DAYS, '2h'],
     [TWO_WEEKS, '1h'],
@@ -129,14 +129,14 @@ const intervalLadders: Record<MetricsDataIntervalLadder, GranularityLadder> = {
 };
 
 // Wraps getInterval since other users of this function, and other metric use cases do not have support for 10s granularity
-export function getDDMInterval(
+export function getMetricsInterval(
   datetimeObj: DateTimeObject,
   useCase: UseCase,
-  ladder: MetricsDataIntervalLadder = 'ddm'
+  ladder: MetricsDataIntervalLadder = 'metrics'
 ) {
   const diffInMinutes = getDiffInMinutes(datetimeObj);
 
-  if (diffInMinutes <= ONE_HOUR && useCase === 'custom' && ladder === 'ddm') {
+  if (diffInMinutes <= ONE_HOUR && useCase === 'custom' && ladder === 'metrics') {
     return '10s';
   }
 

static/app/utils/metrics/useMetricsQuery.spec.tsx

@@ -233,7 +233,7 @@ describe('getMetricsQueryApiRequestPayload', () => {
     };
 
     const result = getMetricsQueryApiRequestPayload([metric], filters, {
-      intervalLadder: 'ddm',
+      intervalLadder: 'metrics',
     });
 
     expect(result.query).toEqual({

static/app/utils/metrics/useMetricsQuery.tsx

@@ -2,7 +2,7 @@ import {useMemo} from 'react';
 
 import type {PageFilters} from 'sentry/types';
 import {parsePeriodToHours} from 'sentry/utils/dates';
-import {getDateTimeParams, getDDMInterval} from 'sentry/utils/metrics';
+import {getDateTimeParams, getMetricsInterval} from 'sentry/utils/metrics';
 import {getUseCaseFromMRI, MRIToField} from 'sentry/utils/metrics/mri';
 import {useApiQuery} from 'sentry/utils/queryClient';
 import useOrganization from 'sentry/utils/useOrganization';
@@ -62,7 +62,7 @@ const getQueryInterval = (
   intervalLadder?: MetricsDataIntervalLadder
 ) => {
   const useCase = getUseCaseFromMRI(query.mri) ?? 'custom';
-  return getDDMInterval(datetime, useCase, intervalLadder);
+  return getMetricsInterval(datetime, useCase, intervalLadder);
 };
 
 export function isMetricFormula(

static/app/views/alerts/rules/metric/metricRulePresets.tsx

@@ -58,7 +58,7 @@ export function makeDefaultCta({
         end: timePeriod.end,
         utc: timePeriod.utc,
         // 7 days are 9998m in alerts as of a rounding error in the `events-stats` endpoint
-        // We need to round to 7d here to display it correctly in DDM
+        // We need to round to 7d here to display it correctly in Metrics
         statsPeriod: timePeriod.period === '9998m' ? '7d' : timePeriod.period,
         project: projects
           .filter(({slug}) => rule.projects.includes(slug))

static/app/views/dashboards/types.tsx

@@ -24,7 +24,7 @@ export enum DisplayType {
 export enum WidgetType {
   DISCOVER = 'discover',
   ISSUE = 'issue',
-  RELEASE = 'metrics', // TODO(ddm): rename RELEASE to 'release', and METRICS to 'metrics'
+  RELEASE = 'metrics', // TODO(metrics): rename RELEASE to 'release', and METRICS to 'metrics'
   METRICS = 'custom-metrics',
 }
 
@@ -152,5 +152,4 @@ export enum DashboardWidgetSource {
   DASHBOARDS = 'dashboards',
   LIBRARY = 'library',
   ISSUE_DETAILS = 'issueDetail',
-  DDM = 'ddm',
 }