some fixes from testing locally the sentry --> seer connection

Author: giovanni-guidini

src/sentry/api/endpoints/organization_cli_bug_prediction.py

@@ -100,16 +100,18 @@ def post(self, request: Request, organization: Organization) -> Response:
         commit_message = validated_data.get("commit_message")
 
         # Resolve repository
+        # Repository names in the database are stored as "owner/name" (e.g., "getsentry/sentry")
+        full_repo_name = f"{repo_data['owner']}/{repo_data['name']}"
         try:
             repository = self._resolve_repository(
                 organization=organization,
-                repo_name=repo_data["name"],
+                repo_name=full_repo_name,
                 repo_provider=repo_data["provider"],
             )
         except Repository.DoesNotExist:
             return Response(
                 {
-                    "detail": f"Repository {repo_data['owner']}/{repo_data['name']} not found. "
+                    "detail": f"Repository {full_repo_name} not found. "
                     "Please ensure the repository is connected to Sentry via an integration."
                 },
                 status=404,
@@ -159,15 +161,35 @@ def post(self, request: Request, organization: Organization) -> Response:
             return Response(
                 {"detail": "Code review service is temporarily unavailable"}, status=503
             )
-        except ValueError:
+        except ValueError as e:
             logger.exception(
                 "code_review_local.trigger.error",
                 extra={
                     "organization_id": organization.id,
                     "user_id": request.user.id,
+                    "error": str(e),
                 },
             )
+            # Include the error message from Seer if available
+            error_msg = str(e)
+            if "Seer error" in error_msg:
+                return Response({"detail": error_msg}, status=502)
             return Response({"detail": "Failed to start code review analysis"}, status=502)
+        except Exception as e:
+            # Catch-all for unexpected errors
+            logger.exception(
+                "code_review_local.trigger.unexpected_error",
+                extra={
+                    "organization_id": organization.id,
+                    "user_id": request.user.id,
+                    "error_type": type(e).__name__,
+                    "error": str(e),
+                },
+            )
+            return Response(
+                {"detail": f"Unexpected error during code review: {type(e).__name__}"},
+                status=500,
+            )
 
         run_id = trigger_response["run_id"]
 
@@ -262,8 +284,14 @@ def _resolve_repository(
         Raises:
             Repository.DoesNotExist: If repository not found
         """
+        # Map simple provider names to integration provider names
+        # Repositories created via integrations use "integrations:github" format
+        provider_variants = [repo_provider]
+        if not repo_provider.startswith("integrations:"):
+            provider_variants.append(f"integrations:{repo_provider}")
+
         return Repository.objects.get(
-            organization_id=organization.id, name=repo_name, provider=repo_provider
+            organization_id=organization.id, name=repo_name, provider__in=provider_variants
         )
 
     def _poll_seer_for_results(

src/sentry/seer/cli_bug_prediction.py

@@ -55,12 +55,14 @@ def trigger_cli_bug_prediction(
         MaxRetryError: If max retries exceeded
         ValueError: If response is invalid
     """
-    body_dict = {
-        "repo_provider": repo_provider,
-        "repo_owner": repo_owner,
-        "repo_name": repo_name,
-        "repo_external_id": repo_external_id,
-        "base_commit_sha": base_commit_sha,
+    body_dict: dict[str, Any] = {
+        "repo": {
+            "provider": repo_provider,
+            "owner": repo_owner,
+            "name": repo_name,
+            "external_id": repo_external_id,
+            "base_commit_sha": base_commit_sha,
+        },
         "diff": diff,
         "organization_id": organization_id,
         "organization_slug": organization_slug,
@@ -100,16 +102,24 @@ def trigger_cli_bug_prediction(
         raise
 
     if response.status >= 400:
+        # Try to extract error message from Seer's response
+        error_detail = ""
+        try:
+            error_data = json.loads(response.data)
+            error_detail = error_data.get("detail", error_data.get("message", str(error_data)))
+        except (JSONDecodeError, TypeError):
+            error_detail = response.data.decode("utf-8") if response.data else "Unknown error"
+
         logger.error(
             "seer.cli_bug_prediction.trigger.error",
             extra={
                 "organization_id": organization_id,
                 "user_id": user_id,
                 "status_code": response.status,
-                "response_data": response.data,
+                "error_detail": error_detail,
             },
         )
-        raise ValueError(f"Seer returned error status: {response.status}")
+        raise ValueError(f"Seer error ({response.status}): {error_detail}")
 
     try:
         response_data = json.loads(response.data)
@@ -164,11 +174,11 @@ def get_cli_bug_prediction_status(run_id: int) -> dict[str, Any]:
     logger.debug("seer.cli_bug_prediction.status.check", extra={"run_id": run_id})
 
     try:
-        # Use POST with run_id in body for status check (Seer pattern)
-        response = make_signed_seer_api_request(
-            connection_pool=seer_cli_bug_prediction_connection_pool,
-            path=f"/v1/automation/codegen/cli-bug-prediction/{run_id}",
-            body=json.dumps({"run_id": run_id}).encode("utf-8"),
+        # Seer status endpoint uses GET method
+        response = seer_cli_bug_prediction_connection_pool.urlopen(
+            "GET",
+            f"/v1/automation/codegen/cli-bug-prediction/{run_id}",
+            headers={"content-type": "application/json;charset=utf-8"},
             timeout=5,
         )
     except (TimeoutError, MaxRetryError):