Revert "feat(github): Handle installation_repositories webhook (#111864)"

This reverts commit a8a8009.

Co-authored-by: wedamija <6288560+wedamija@users.noreply.github.com>

Author: getsentry-bot

src/sentry/features/temporary.py

@@ -137,7 +137,6 @@ def register_temporary_features(manager: FeatureManager) -> None:
     manager.add("organizations:integrations-cursor", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
     manager.add("organizations:integrations-github-copilot-agent", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
     manager.add("organizations:integrations-github-platform-detection", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
-    manager.add("organizations:github-repo-auto-sync", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
     manager.add("organizations:integrations-perforce", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
     manager.add("organizations:integrations-slack-staging", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
     manager.add("organizations:scm-source-context", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)

src/sentry/integrations/bitbucket/repository.py

@@ -1,4 +1,3 @@
-from collections.abc import Mapping
 from typing import Any
 
 from sentry.integrations.types import IntegrationProviderSlug
@@ -48,7 +47,7 @@ def get_webhook_secret(self, organization):
         return secret
 
     def build_repository_config(
-        self, organization: RpcOrganization, data: Mapping[str, Any]
+        self, organization: RpcOrganization, data: dict[str, Any]
     ) -> RepositoryConfig:
         installation = self.get_installation(data.get("installation"), organization.id)
         client = installation.get_client()

src/sentry/integrations/bitbucket_server/repository.py

@@ -1,4 +1,3 @@
-from collections.abc import Mapping
 from datetime import datetime, timezone
 from typing import Any
 
@@ -36,7 +35,7 @@ def get_repository_data(self, organization, config):
         return config
 
     def build_repository_config(
-        self, organization: RpcOrganization, data: Mapping[str, Any]
+        self, organization: RpcOrganization, data: dict[str, Any]
     ) -> RepositoryConfig:
         installation = self.get_installation(data.get("installation"), organization.id)
         client = installation.get_client()

src/sentry/integrations/github/repository.py

@@ -52,7 +52,7 @@ def get_repository_data(
         return config
 
     def build_repository_config(
-        self, organization: RpcOrganization, data: Mapping[str, Any]
+        self, organization: RpcOrganization, data: dict[str, Any]
     ) -> RepositoryConfig:
         return {
             "name": data["identifier"],

src/sentry/integrations/github/tasks/__init__.py

@@ -2,12 +2,10 @@
 from .codecov_account_unlink import codecov_account_unlink
 from .link_all_repos import link_all_repos
 from .pr_comment import github_comment_workflow
-from .sync_repos_on_install_change import sync_repos_on_install_change
 
 __all__ = (
     "codecov_account_link",
     "codecov_account_unlink",
     "github_comment_workflow",
     "link_all_repos",
-    "sync_repos_on_install_change",
 )

src/sentry/integrations/github/tasks/link_all_repos.py

@@ -1,5 +1,4 @@
 import logging
-from collections.abc import Mapping
 from typing import Any
 
 from taskbroker_client.retry import Retry
@@ -14,7 +13,6 @@
 from sentry.organizations.services.organization import organization_service
 from sentry.plugins.providers.integration_repository import (
     RepoExistsError,
-    RepositoryInputConfig,
     get_integration_repository_provider,
 )
 from sentry.shared_integrations.exceptions import ApiError
@@ -25,9 +23,9 @@
 logger = logging.getLogger(__name__)
 
 
-def get_repo_config(repo: Mapping[str, Any], integration_id: int) -> RepositoryInputConfig:
+def get_repo_config(repo, integration_id):
     return {
-        "external_id": str(repo["id"]),
+        "external_id": repo["id"],
         "integration_id": integration_id,
         "identifier": repo["full_name"],
     }
@@ -79,7 +77,7 @@ def link_all_repos(
 
         integration_repo_provider = get_integration_repository_provider(integration)
 
-        repo_configs: list[RepositoryInputConfig] = []
+        repo_configs: list[dict[str, Any]] = []
         missing_repos = []
         for repo in repositories:
             try:

src/sentry/integrations/github/tasks/sync_repos_on_install_change.py

@@ -30,7 +30,6 @@
 from sentry.integrations.github.webhook_types import (
     GITHUB_WEBHOOK_TYPE_HEADER_KEY,
     GithubWebhookType,
-    InstallationRepositoriesEvent,
 )
 from sentry.integrations.pipeline import ensure_integration
 from sentry.integrations.services.integration.model import (
@@ -419,57 +418,6 @@ def _handle_organization_deletion(
             )
 
 
-class InstallationRepositoriesEventWebhook(GitHubWebhook):
-    """
-    Handles installation_repositories events when repos are added to or
-    removed from the GitHub App installation. Runs in control silo.
-
-    https://docs.github.com/en/webhooks/webhook-events-and-payloads#installation_repositories
-    """
-
-    EVENT_TYPE = IntegrationWebhookEventType.INSTALLATION_REPOSITORIES
-
-    def __call__(  # type: ignore[override]
-        self, event: InstallationRepositoriesEvent, host: str | None = None, **kwargs: Any
-    ) -> None:
-        external_id = get_github_external_id(event=event, host=host)
-        if external_id is None:
-            return
-
-        result = integration_service.organization_contexts(
-            provider=self.provider,
-            external_id=external_id,
-        )
-        integration = result.integration
-
-        if integration is None:
-            logger.warning(
-                "github.installation_repositories.missing_integration",
-                extra={"external_id": str(external_id)},
-            )
-            return
-
-        action = event["action"]
-        repos_added = event["repositories_added"]
-        repos_removed = event["repositories_removed"]
-        repository_selection = event["repository_selection"]
-
-        if not repos_added and not repos_removed:
-            return
-
-        from .tasks.sync_repos_on_install_change import sync_repos_on_install_change
-
-        sync_repos_on_install_change.apply_async(
-            kwargs={
-                "integration_id": integration.id,
-                "action": action,
-                "repos_added": repos_added,
-                "repos_removed": repos_removed,
-                "repository_selection": repository_selection,
-            }
-        )
-
-
 class PushEventWebhook(GitHubWebhook):
     """https://developer.github.com/v3/activity/events/types/#pushevent"""
 
@@ -1010,7 +958,6 @@ class GitHubIntegrationsWebhookEndpoint(Endpoint):
     _handlers: dict[GithubWebhookType, type[GitHubWebhook]] = {
         GithubWebhookType.CHECK_RUN: CheckRunEventWebhook,
         GithubWebhookType.INSTALLATION: InstallationEventWebhook,
-        GithubWebhookType.INSTALLATION_REPOSITORIES: InstallationRepositoriesEventWebhook,
         GithubWebhookType.ISSUE: IssuesEventWebhook,
         GithubWebhookType.ISSUE_COMMENT: IssueCommentEventWebhook,
         GithubWebhookType.PULL_REQUEST: PullRequestEventWebhook,

src/sentry/integrations/github/webhook.py

@@ -1,7 +1,6 @@
 from __future__ import annotations
 
 from enum import StrEnum
-from typing import Any, Literal, TypedDict
 
 GITHUB_WEBHOOK_TYPE_HEADER = "HTTP_X_GITHUB_EVENT"
 GITHUB_WEBHOOK_TYPE_HEADER_KEY = "X-GITHUB-EVENT"
@@ -23,25 +22,7 @@ class GithubWebhookType(StrEnum):
 
 
 # Event type strings (X-GitHub-Event header values) that the cell webhook endpoint processes.
-# INSTALLATION and INSTALLATION_REPOSITORIES are handled in control only.
-_CONTROL_ONLY_EVENTS = frozenset(
-    {GithubWebhookType.INSTALLATION, GithubWebhookType.INSTALLATION_REPOSITORIES}
-)
+# INSTALLATION is handled in control only.
 CELL_PROCESSED_GITHUB_EVENTS = frozenset(
-    t.value for t in GithubWebhookType if t not in _CONTROL_ONLY_EVENTS
+    t.value for t in GithubWebhookType if t != GithubWebhookType.INSTALLATION
 )
-
-
-class GitHubInstallationRepo(TypedDict):
-    id: int
-    full_name: str
-    private: bool
-
-
-class InstallationRepositoriesEvent(TypedDict):
-    action: Literal["added", "removed"]
-    installation: dict[str, Any]
-    repositories_added: list[GitHubInstallationRepo]
-    repositories_removed: list[GitHubInstallationRepo]
-    repository_selection: Literal["all", "selected"]
-    sender: dict[str, Any]

src/sentry/integrations/github/webhook_types.py

@@ -1,4 +1,3 @@
-from collections.abc import Mapping
 from typing import Any
 
 from sentry.integrations.github.repository import GitHubRepositoryProvider
@@ -30,7 +29,7 @@ def _validate_repo(self, client, installation, repo):
         return repo_data
 
     def build_repository_config(
-        self, organization: RpcOrganization, data: Mapping[str, Any]
+        self, organization: RpcOrganization, data: dict[str, Any]
     ) -> RepositoryConfig:
         integration = integration_service.get_integration(
             integration_id=data["integration_id"], provider=self.repo_provider