ref(seer): Remove should_run_automation from get_issue_summary

src/sentry/integrations/utils/issue_summary_for_alerts.py

@@ -3,12 +3,13 @@
 from typing import Any
 
 import sentry_sdk
+from django.contrib.auth.models import AnonymousUser
 
 from sentry import features, options
 from sentry.issues.grouptype import GroupCategory
 from sentry.models.group import Group
 from sentry.seer.autofix.constants import SeerAutomationSource
-from sentry.seer.autofix.issue_summary import get_issue_summary
+from sentry.seer.autofix.issue_summary import get_issue_summary, run_automation
 from sentry.seer.autofix.utils import is_seer_scanner_rate_limited
 from sentry.utils.concurrent import ContextPropagatingThreadPoolExecutor
 
@@ -52,9 +53,19 @@ def fetch_issue_summary(group: Group) -> dict[str, Any] | None:
                 future = executor.submit(
                     get_issue_summary, group, source=SeerAutomationSource.ALERT
                 )
-                summary_result, status_code = future.result(timeout=timeout)
+                summary_result, status_code, event = future.result(timeout=timeout)
 
                 if status_code == 200:
+                    if event is not None:
+                        try:
+                            run_automation(
+                                group, AnonymousUser(), event, SeerAutomationSource.ALERT
+                            )
+                        except Exception:
+                            logger.exception(
+                                "seer.automation.run_automation_failed",
+                                extra={"group_id": group.id},
+                            )
                     return summary_result
                 return None
     except concurrent.futures.TimeoutError:

src/sentry/seer/autofix/issue_summary.py

@@ -520,15 +520,13 @@ def _generate_summary(
     group: Group,
     user: User | RpcUser | AnonymousUser,
     force_event_id: str | None,
-    source: SeerAutomationSource,
     cache_key: str,
-    should_run_automation: bool = True,
-) -> tuple[dict[str, Any], int]:
+) -> tuple[dict[str, Any], int, GroupEvent | None]:
     """Core logic to generate and cache the issue summary."""
     serialized_event, event = _get_event(group, user, provided_event_id=force_event_id)
 
     if not serialized_event or not event:
-        return {"detail": "Could not find an event for the issue"}, 400
+        return {"detail": "Could not find an event for the issue"}, 400, None
 
     trace_tree = None
     if event:
@@ -571,15 +569,7 @@ def _generate_summary(
     summary_dict["event_id"] = event.event_id
     cache.set(cache_key, summary_dict, timeout=int(timedelta(days=7).total_seconds()))
 
-    if should_run_automation:
-        try:
-            run_automation(group, user, event, source)
-        except Exception:
-            logger.exception(
-                "Error auto-triggering autofix from issue summary", extra={"group_id": group.id}
-            )
-
-    return summary_dict, 200
+    return summary_dict, 200, event
 
 
 def _log_seer_scanner_billing_event(group: Group, source: SeerAutomationSource):
@@ -604,8 +594,7 @@ def get_issue_summary(
     user: User | RpcUser | AnonymousUser | None = None,
     force_event_id: str | None = None,
     source: SeerAutomationSource = SeerAutomationSource.ISSUE_DETAILS,
-    should_run_automation: bool = True,
-) -> tuple[dict[str, Any], int]:
+) -> tuple[dict[str, Any], int, GroupEvent | None]:
     """
     Generate an AI summary for an issue.
 
@@ -614,18 +603,17 @@ def get_issue_summary(
         user: The user requesting the summary
         force_event_id: Optional event ID to force summarizing a specific event
         source: The source triggering the summary generation
-        should_run_automation: Whether to trigger automation after generating summary
 
     Returns:
-        A tuple containing (summary_data, status_code)
+        A tuple containing (summary_data, status_code, event)
     """
     if user is None:
         user = AnonymousUser()
     if not features.has("organizations:gen-ai-features", group.organization, actor=user):
-        return {"detail": "Feature flag not enabled"}, 400
+        return {"detail": "Feature flag not enabled"}, 400, None
 
     if group.organization.get_option("sentry:hide_ai_features"):
-        return {"detail": "AI features are disabled for this organization."}, 403
+        return {"detail": "AI features are disabled for this organization."}, 403, None
 
     cache_key = get_issue_summary_cache_key(group.id)
     lock_key, lock_name = get_issue_summary_lock_key(group.id)
@@ -634,15 +622,13 @@ def get_issue_summary(
 
     # if force_event_id is set, we always generate a new summary
     if force_event_id:
-        summary_dict, status_code = _generate_summary(
-            group, user, force_event_id, source, cache_key, should_run_automation
-        )
+        summary_dict, status_code, event = _generate_summary(group, user, force_event_id, cache_key)
         _log_seer_scanner_billing_event(group, source)
-        return convert_dict_key_case(summary_dict, snake_to_camel_case), status_code
+        return convert_dict_key_case(summary_dict, snake_to_camel_case), status_code, event
 
     # 1. Check cache first
     if cached_summary := cache.get(cache_key):
-        return convert_dict_key_case(cached_summary, snake_to_camel_case), 200
+        return convert_dict_key_case(cached_summary, snake_to_camel_case), 200, None
 
     # 2. Try to acquire lock
     try:
@@ -653,17 +639,17 @@ def get_issue_summary(
             # Re-check cache after acquiring lock, in case another process finished
             # while we were waiting for the lock.
             if cached_summary := cache.get(cache_key):
-                return convert_dict_key_case(cached_summary, snake_to_camel_case), 200
+                return convert_dict_key_case(cached_summary, snake_to_camel_case), 200, None
 
             # Lock acquired and cache is still empty, proceed with generation
-            summary_dict, status_code = _generate_summary(
-                group, user, force_event_id, source, cache_key, should_run_automation
+            summary_dict, status_code, event = _generate_summary(
+                group, user, force_event_id, cache_key
             )
             _log_seer_scanner_billing_event(group, source)
-            return convert_dict_key_case(summary_dict, snake_to_camel_case), status_code
+            return convert_dict_key_case(summary_dict, snake_to_camel_case), status_code, event
 
     except UnableToAcquireLock:
         # Failed to acquire lock within timeout. Check cache one last time.
         if cached_summary := cache.get(cache_key):
-            return convert_dict_key_case(cached_summary, snake_to_camel_case), 200
-        return {"detail": "Timeout waiting for summary generation lock"}, 503
+            return convert_dict_key_case(cached_summary, snake_to_camel_case), 200, None
+        return {"detail": "Timeout waiting for summary generation lock"}, 503, None

src/sentry/seer/endpoints/group_ai_summary.py

@@ -43,7 +43,7 @@ def post(self, request: Request, group: Group) -> Response:
         data = orjson.loads(request.body) if request.body else {}
         force_event_id = data.get("event_id", None)
 
-        summary_data, status_code = get_issue_summary(
+        summary_data, status_code, _ = get_issue_summary(
             group=group,
             user=request.user,
             force_event_id=force_event_id,

src/sentry/tasks/post_process.py

@@ -1529,7 +1529,7 @@ def kick_off_seer_automation(job: PostProcessJob) -> None:
         is_seer_seat_based_tier_enabled,
     )
     from sentry.tasks.seer.autofix import (
-        generate_issue_summary_only,
+        generate_summary_and_fixability_score,
         generate_summary_and_run_automation,
         run_automation_only_task,
     )
@@ -1555,7 +1555,7 @@ def kick_off_seer_automation(job: PostProcessJob) -> None:
                 "seer.automation.filtered", tags={"reason": skip_reason, "tier": "seat_based"}
             )
             if skip_reason == "below_occurrence_threshold":
-                generate_issue_summary_only.delay(group.id)
+                generate_summary_and_fixability_score.delay(group.id)
             return
 
         # Check if summary exists in cache

src/sentry/tasks/seer/autofix.py

@@ -74,7 +74,9 @@ def check_autofix_status(run_id: int, organization_id: int) -> None:
     retry=Retry(times=1),
 )
 def generate_summary_and_run_automation(group_id: int, **kwargs) -> None:
-    from sentry.seer.autofix.issue_summary import get_issue_summary
+    from django.contrib.auth.models import AnonymousUser
+
+    from sentry.seer.autofix.issue_summary import get_issue_summary, run_automation
 
     trigger_path = kwargs.get("trigger_path", "unknown")
     sentry_sdk.set_tag("trigger_path", trigger_path)
@@ -98,7 +100,12 @@ def generate_summary_and_run_automation(group_id: int, **kwargs) -> None:
             )
         )
 
-    get_issue_summary(group=group, source=SeerAutomationSource.POST_PROCESS)
+    _, status_code, event = get_issue_summary(group=group, source=SeerAutomationSource.POST_PROCESS)
+    if status_code == 200 and event is not None:
+        try:
+            run_automation(group, AnonymousUser(), event, SeerAutomationSource.POST_PROCESS)
+        except Exception:
+            logger.exception("seer.automation.run_automation_failed", extra={"group_id": group.id})
 
 
 @instrumented_task(
@@ -107,7 +114,7 @@ def generate_summary_and_run_automation(group_id: int, **kwargs) -> None:
     processing_deadline_duration=35,
     retry=Retry(times=3, delay=3, on=(Exception,)),
 )
-def generate_issue_summary_only(group_id: int) -> None:
+def generate_summary_and_fixability_score(group_id: int) -> None:
     """
     Generate issue summary WITHOUT triggering automation.
     Used for triage signals flow when event count < AUTOFIX_AUTOMATION_OCCURRENCE_THRESHOLD or when summary doesn't exist yet.
@@ -137,9 +144,7 @@ def generate_issue_summary_only(group_id: int) -> None:
         )
 
     # Generate and cache the summary
-    get_issue_summary(
-        group=group, source=SeerAutomationSource.POST_PROCESS, should_run_automation=False
-    )
+    get_issue_summary(group=group, source=SeerAutomationSource.POST_PROCESS)
 
     get_and_update_group_fixability_score(group, force_generate=True)
 

tests/sentry/integrations/slack/test_message_builder.py

@@ -946,7 +946,7 @@ def test_build_group_block_with_ai_summary(self) -> None:
             patch(patch_path) as mock_get_summary,
             patch(serializer_path, serializer_mock),
         ):
-            mock_get_summary.return_value = (mock_summary, 200)
+            mock_get_summary.return_value = (mock_summary, 200, None)
 
             blocks = SlackIssuesMessageBuilder(group).build()
 
@@ -1037,7 +1037,7 @@ def test_build_group_block_with_ai_summary_text_truncation(self) -> None:
             patch(patch_path) as mock_get_summary,
             patch(serializer_path, serializer_mock),
         ):
-            mock_get_summary.return_value = (mock_summary, 200)
+            mock_get_summary.return_value = (mock_summary, 200, None)
             blocks = SlackIssuesMessageBuilder(group1, event1.for_group(group1)).build()
             title_text = blocks["blocks"][0]["text"]["text"]
 
@@ -1049,7 +1049,7 @@ def test_build_group_block_with_ai_summary_text_truncation(self) -> None:
             patch(patch_path) as mock_get_summary,
             patch(serializer_path, serializer_mock),
         ):
-            mock_get_summary.return_value = (mock_summary, 200)
+            mock_get_summary.return_value = (mock_summary, 200, None)
             blocks = SlackIssuesMessageBuilder(group2, event2.for_group(group2)).build()
             title_text = blocks["blocks"][0]["text"]["text"]
 
@@ -1092,7 +1092,7 @@ def test_build_group_block_with_ai_summary_text_truncation(self) -> None:
                 patch(patch_path) as mock_get_summary,
                 patch(serializer_path, serializer_mock),
             ):
-                mock_get_summary.return_value = (mock_summary, 200)
+                mock_get_summary.return_value = (mock_summary, 200, None)
                 blocks = SlackIssuesMessageBuilder(group_lb, event_lb.for_group(group_lb)).build()
                 title_block = blocks["blocks"][0]["text"]["text"]
                 assert f": {expected_headline_part}*>" in title_block, f"Failed for {name}"
@@ -1184,7 +1184,7 @@ def test_compact_alerts_with_ai_summary(self) -> None:
             patch(patch_path) as mock_get_summary,
             patch(serializer_path, serializer_mock),
         ):
-            mock_get_summary.return_value = (mock_summary, 200)
+            mock_get_summary.return_value = (mock_summary, 200, None)
 
             blocks = SlackIssuesMessageBuilder(group).build()
 

tests/sentry/integrations/utils/test_issue_summary_for_alerts.py

@@ -67,7 +67,7 @@ def test_fetch_issue_summary_with_hide_ai_features_disabled(
             "whatsWrong": "Something went wrong",
             "possibleCause": "Test cause",
         }
-        mock_get_issue_summary.return_value = (mock_summary, 200)
+        mock_get_issue_summary.return_value = (mock_summary, 200, None)
 
         result = fetch_issue_summary(self.group)
 
@@ -174,7 +174,7 @@ def test_fetch_issue_summary_api_error(
         mock_has_budget.return_value = True
 
         # Mock error response
-        mock_get_issue_summary.return_value = (None, 500)
+        mock_get_issue_summary.return_value = (None, 500, None)
 
         result = fetch_issue_summary(self.group)