feat(incidents): Add is_metric_subscription_allowed; use it#112241
Merged
feat(incidents): Add is_metric_subscription_allowed; use it#112241
Conversation
github-actions
bot
added
the
Scope: Backend
ceorourke
approved these changes
Apr 6, 2026
|
|
||
| Returns True if allowed, False if the organization lacks the required features | ||
| (e.g. after a plan downgrade). | ||
| """ |
Member
There was a problem hiding this comment.
nit: maybe make a has_incidents var to reuse?
george-sentry
pushed a commit
that referenced
this pull request
Apr 9, 2026
There are a couple places where we check features and datasets to determine whether a subscription is allowed to be enabled. This defines that somewhere central and uses it in subscription processing. Once it lands, we'll extend it to some getsentry logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a couple places where we check features and datasets to determine whether a subscription is allowed to be enabled.
This defines that somewhere central and uses it in subscription processing.
Once it lands, we'll extend it to some getsentry logic.