Skip to content

ref(issues): Remove streamlined UI from stack trace files#112242

Merged
malwilley merged 4 commits intomasterfrom
malwilley/rm-has-streamlined
Apr 6, 2026
Merged

ref(issues): Remove streamlined UI from stack trace files#112242
malwilley merged 4 commits intomasterfrom
malwilley/rm-has-streamlined

Conversation

@malwilley
Copy link
Copy Markdown
Member

Continuing the code deletion of old issues UI

@malwilley malwilley requested a review from scttcper April 3, 2026 22:24
@malwilley malwilley requested a review from a team as a code owner April 3, 2026 22:25
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 3, 2026
setIsCollapsed(false);
}
// Expand the section
setIsCollapsed(false);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this just be the new default

Copy link
Copy Markdown
Member Author

@malwilley malwilley Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is correct as-is? it seems to be opening a different section on the page

event={event}
meta={meta}
hideIcon={hasStreamlinedUI}
hideIcon
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we can remove the icon then

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes true, that allowed me to remove a lot more code related to the platform icon

Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f7af708. Configure here.

<StackTraceContentPanel
className={wrapperClassName}
data-test-id="stack-trace-content"
hideIcon={hideIcon}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrapper components now serve no purpose after icon removal

Low Severity

The Wrapper styled component in both content.tsx and nativeContent.tsx existed solely to provide a position: relative containing block for the absolutely-positioned StacktracePlatformIcon. Now that the icon is removed, Wrapper is an unnecessary DOM node — Panel (which ContentPanel/StackTraceContentPanel extends) already has position: relative. Since this is a cleanup PR, these leftover wrappers are a natural candidate for removal.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit f7af708. Configure here.

@malwilley malwilley merged commit a42598b into master Apr 6, 2026
74 checks passed
@malwilley malwilley deleted the malwilley/rm-has-streamlined branch April 6, 2026 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants