[DRAFT] Remove filter_aliases from untyped mypy module list#117049
Draft
cursor[bot] wants to merge 2 commits into
Draft
[DRAFT] Remove filter_aliases from untyped mypy module list#117049cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
Co-authored-by: Armen Zambrano G. <armenzg@users.noreply.github.com>
Co-authored-by: Armen Zambrano G. <armenzg@users.noreply.github.com>
github-actions
Bot
added
the
Scope: Backend
Contributor
Backend Test FailuresFailures on
|
Contributor
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sentry.search.events.datasets.filter_aliasesfrom the mypy module ignore list inpyproject.tomlsrc/sentry/search/events/datasets/filter_aliases.pyby adding explicit string/value narrowing forSearchValue.raw_valueTesting
.venv/bin/python -m mypy src/sentry/search/events/datasets/filter_aliases.py.venv/bin/python -c "from tests.sentry.test_mypy_stronglist import test_stronglist; test_stronglist(); print('test_stronglist passed')".venv/bin/prek run -q --files pyproject.toml src/sentry/search/events/datasets/filter_aliases.pyNotes
make test-selectivecould not run in this VM becausegcloudis unavailable.pytest tests/sentry/test_mypy_stronglist.pysetup/teardown requires Redis; Docker daemon is unavailable in this VM, so I validated with direct execution oftest_stronglist()instead.@armenzg could you please review this draft PR?
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.