fix(rpc): remove non-array attributes from json array allowlist#7950
Merged
phacops merged 4 commits intoJun 28, 2026
Merged
Conversation
Re-apply after merging master: drop gen_ai.system_instructions, gen_ai.response.object, gen_ai.tool.call.arguments and gen_ai.tool.input from ATTRIBUTES_ARRAY_ALLOWLIST (string/dict values, not arrays), keeping master's workflow_ids/triggered_workflow_ids/action_filter_group_ids/ triggered_action_ids. Point the array-attribute test at workflow_ids, since gen_ai.tool.input is no longer an allowlisted array path.
phacops
approved these changes
Jun 28, 2026
phacops
deleted the
shellmayr/fix/remove-non-array-attributes-from-allowlist
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gen_ai.system_instructions: string valuegen_ai.response.object: not in conventions anymore, seems to be an old attribute - most likely not an arraygen_ai.tool.call.arguments: dict, not listgen_ai.tool.input: dict, not list