Skip to content

Commit 9a4fe35

Browse files
Apply first suggestions from Hidde's review.
Co-authored-by: Hidde Beydals <hiddeco@users.noreply.github.com> Signed-off-by: Felix Fontein <felix@fontein.de>
1 parent bd443e1 commit 9a4fe35

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

stores/flatten.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ func flattenDescendArray(array []interface{}, prefix string, destination sops.Tr
246246
if err != nil {
247247
return nil, err
248248
}
249-
i += 1
249+
i++
250250
}
251251
return destination, nil
252252
}

stores/metadata.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ type MetadataOpts struct {
2424
Flatten MetadataFlatten
2525
}
2626

27-
// SopsPrefix is the prefix for all metadatada entry keys
27+
// SopsPrefix is the prefix for all metadata entry keys.
2828
const SopsPrefix = SopsMetadataKey + "_"
2929

3030
func sopsToGoMap(mapping sops.TreeBranch) (map[string]interface{}, error) {
@@ -112,15 +112,15 @@ func ExtractMetadata(branches sops.TreeBranches, opts MetadataOpts) (sops.TreeBr
112112
}
113113
branch = append(branch[:i], branch[i+1:]...)
114114
} else {
115-
i += 1
115+
i++
116116
}
117117
}
118118
branches[bi] = branch
119119
}
120120
} else {
121121
if len(branches) >= 1 {
122122
branch := branches[0]
123-
for i := 0; i < len(branch); i += 1 {
123+
for i := 0; i < len(branch); i++ {
124124
if key, ok := branch[i].Key.(string); ok {
125125
if strings.HasPrefix(key, SopsPrefix) {
126126
entry := branch[i]
@@ -241,7 +241,7 @@ func metadataToTreeBranch(md metadata) (sops.TreeBranch, error) {
241241
func SerializeMetadata(data sops.Tree, opts MetadataOpts) (sops.TreeBranches, error) {
242242
md, err := metadataToTreeBranch(metadataFromInternal(data.Metadata))
243243
if err != nil {
244-
return nil, fmt.Errorf("Error while serializing metadata: %e", err)
244+
return nil, fmt.Errorf("Error while serializing metadata: %w", err)
245245
}
246246
if opts.Flatten != MetadataFlattenNone {
247247
var prefix string
@@ -250,7 +250,7 @@ func SerializeMetadata(data sops.Tree, opts MetadataOpts) (sops.TreeBranches, er
250250
}
251251
md, err = flattenTreeBranch(md, prefix)
252252
if err != nil {
253-
return nil, fmt.Errorf("Error while flatting metadata: %e", err)
253+
return nil, fmt.Errorf("Error while flattening metadata: %w", err)
254254
}
255255
}
256256
if opts.Flatten != MetadataFlattenFull {

0 commit comments

Comments
 (0)