Drop unused newline-escaping helpers

`EncodeNewLines` and `DecodeNewLines` escaped or unescaped `\n` for
every string value in a metadata map, and were applied to the
flattened metadata before it was handed to the INI/dotenv writers.
After the move to a single `SerializeMetadata` pipeline they are no
longer called: each store handles newline escaping at the file
boundary itself.

Signed-off-by: Hidde Beydals <hidde@hhh.computer>

Author: hiddeco

stores/stores.go

@@ -606,22 +606,3 @@ func ValToString(v interface{}) string {
 	}
 }
 
-// DecodeNewLines replaces \\n with \n for all string values in the map.
-// Used by config stores that do not handle multi-line values (ini, dotenv).
-func DecodeNewLines(m map[string]interface{}) {
-	for k, v := range m {
-		if s, ok := v.(string); ok {
-			m[k] = strings.Replace(s, "\\n", "\n", -1)
-		}
-	}
-}
-
-// EncodeNewLines replaces \n with \\n for all string values in the map.
-// Used by config stores that do not handle multi-line values (ini, dotenv).
-func EncodeNewLines(m map[string]interface{}) {
-	for k, v := range m {
-		if s, ok := v.(string); ok {
-			m[k] = strings.Replace(s, "\n", "\\n", -1)
-		}
-	}
-}

stores/stores_test.go

@@ -26,36 +26,3 @@ func TestValToString(t *testing.T) {
 	assert.Equal(t, "a string", ValToString("a string"))
 }
 
-func TestDecodeNewLines(t *testing.T) {
-	tests := []struct {
-		input map[string]interface{}
-		want  map[string]interface{}
-	}{
-		{map[string]interface{}{"mac": "line1\\nline2"}, map[string]interface{}{"mac": "line1\nline2"}},
-		{map[string]interface{}{"mac": "line1\\n\\n\\nline2\\n\\nline3"}, map[string]interface{}{"mac": "line1\n\n\nline2\n\nline3"}},
-	}
-
-	for _, tt := range tests {
-		DecodeNewLines(tt.input)
-		for k, v := range tt.want {
-			assert.Equal(t, v, tt.input[k])
-		}
-	}
-}
-
-func TestEncodeNewLines(t *testing.T) {
-	tests := []struct {
-		input map[string]interface{}
-		want  map[string]interface{}
-	}{
-		{map[string]interface{}{"mac": "line1\nline2"}, map[string]interface{}{"mac": "line1\\nline2"}},
-		{map[string]interface{}{"mac": "line1\n\n\nline2\n\nline3"}, map[string]interface{}{"mac": "line1\\n\\n\\nline2\\n\\nline3"}},
-	}
-
-	for _, tt := range tests {
-		EncodeNewLines(tt.input)
-		for k, v := range tt.want {
-			assert.Equal(t, v, tt.input[k])
-		}
-	}
-}