fix(auth): add timeout handling for oauth fetch requests

Author: udaycodespace

apps/dashboard-api/src/controllers/auth.controller.js

@@ -87,20 +87,35 @@ const clearGithubStateCookie = (res) => {
     });
 };
 
+const OAUTH_FETCH_TIMEOUT_MS = 10000;
+
 const fetchJson = async (url, options, defaultMessage) => {
-    const response = await fetch(url, options);
-    const payload = await response.json().catch(() => null);
-
-    if (!response.ok) {
-        const message =
-            payload?.error_description ||
-            payload?.error ||
-            payload?.message ||
-            defaultMessage;
-        throw new Error(message);
-    }
+    // Prevent OAuth requests from hanging forever
+    const controller = new AbortController();
+    const timeout = setTimeout(() => controller.abort(), OAUTH_FETCH_TIMEOUT_MS);
+
+    try {
+        const response = await fetch(url, { signal: controller.signal, ...options });
+        const payload = await response.json().catch(() => null);
+
+        if (!response.ok) {
+            const message =
+                payload?.error_description ||
+                payload?.error ||
+                payload?.message ||
+                defaultMessage;
+            throw new Error(message);
+        }
 
-    return payload;
+        return payload;
+    } catch (err) {
+        if (err.name === 'AbortError') {
+            throw new Error('OAuth request timed out.');
+        }
+        throw err;
+    } finally {
+        clearTimeout(timeout);
+    }
 };
 
 const exchangeGithubCodeForToken = async ({ code, req }) => {