fix: store external storage config correctly for s3, r2, gcs

Author: yash-pouranik

apps/dashboard-api/src/controllers/project.controller.js

@@ -740,16 +740,30 @@ module.exports.updateExternalConfig = async (req, res) => {
       }
     }
 
-    if (storageUrl && storageKey) {
-      const storageConfig = {
-        storageUrl,
-        storageKey,
-        storageProvider: storageProvider || "supabase",
-      };
-      updateData["resources.storage.config"] = encrypt(
-        JSON.stringify(storageConfig),
-      );
-      updateData["resources.storage.isExternal"] = true;
+    if (storageProvider === "supabase" || (!storageProvider && storageUrl && storageKey)) {
+      if (storageUrl && storageKey) {
+        const storageConfig = {
+          storageUrl,
+          storageKey,
+          storageProvider: "supabase",
+        };
+        updateData["resources.storage.config"] = encrypt(JSON.stringify(storageConfig));
+        updateData["resources.storage.isExternal"] = true;
+      }
+    } else if (["s3", "cloudflare_r2", "gcs"].includes(storageProvider)) {
+      if (validatedData.s3AccessKeyId && validatedData.s3SecretAccessKey && validatedData.s3Bucket) {
+        const storageConfig = {
+          storageProvider,
+          accessKeyId: validatedData.s3AccessKeyId,
+          secretAccessKey: validatedData.s3SecretAccessKey,
+          region: validatedData.s3Region,
+          endpoint: validatedData.s3Endpoint,
+          bucket: validatedData.s3Bucket,
+          publicUrlHost: validatedData.publicUrlHost,
+        };
+        updateData["resources.storage.config"] = encrypt(JSON.stringify(storageConfig));
+        updateData["resources.storage.isExternal"] = true;
+      }
     }
 
     const project = await Project.findOneAndUpdate(

apps/landing/.vercel/output/config.json

@@ -0,0 +1,20 @@
+{
+	"version": 3,
+	"routes": [
+		{
+			"handle": "filesystem"
+		},
+		{
+			"src": "^/_astro/(.*)$",
+			"headers": {
+				"cache-control": "public, max-age=31536000, immutable"
+			},
+			"continue": true
+		},
+		{
+			"src": "^/.*$",
+			"dest": "/404.html",
+			"status": 404
+		}
+	]
+}