feat: Add "Home" button to signup page - #235
Conversation
📝 WalkthroughWalkthroughAuthShell component is extended with an optional ChangesAuth Mode Click Navigation
Vite Build Configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
apps/web-dashboard/src/index.css (1)
869-873: 💤 Low valueRedundant background assignment in hover state.
The hover rule sets
background: var(--color-auth-mode-bg), which is already the default background defined in.auth-form-card__mode(line 856). The hover visual feedback is effectively provided by the color and text-decoration changes alone.♻️ Optional cleanup
.auth-form-card__mode--clickable:hover { - background: var(--color-auth-mode-bg); color: var(--color-primary); text-decoration: underline; }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/web-dashboard/src/index.css` around lines 869 - 873, The hover rule for .auth-form-card__mode--clickable:hover redundantly reassigns background to var(--color-auth-mode-bg) which is already set on .auth-form-card__mode; remove the background declaration from the :hover block so the hover only changes color and text-decoration (leave .auth-form-card__mode and .auth-form-card__mode--clickable:hover selectors intact).apps/web-dashboard/src/components/AuthShell.jsx (1)
22-29: 💤 Low valueConsider moving inline button-reset styles to CSS.
The inline styles
{ background: 'none', border: 'none', cursor: 'pointer', padding: 0 }duplicate logic that could live in the.auth-form-card__mode--clickableclass for better maintainability and consistency with the existing design system.♻️ Refactor to consolidate styles in CSS
In
index.css, update the clickable class to include button-reset properties:.auth-form-card__mode--clickable { + background: none; + border: none; + padding: 0; cursor: pointer; transition: all 0.2s ease; }Then remove the inline
styleprop from the button:<button type="button" className="auth-form-card__mode auth-form-card__mode--clickable" onClick={onModeClick} - style={{ background: 'none', border: 'none', cursor: 'pointer', padding: 0 }} > {modeLabel} </button>🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/web-dashboard/src/components/AuthShell.jsx` around lines 22 - 29, Move the inline button-reset styles out of the JSX and into the CSS class: update the .auth-form-card__mode--clickable rule in your stylesheet to include background: none, border: none, cursor: pointer, and padding: 0, then remove the style prop from the button element in AuthShell.jsx (the button that uses className "auth-form-card__mode auth-form-card__mode--clickable" and onClick={onModeClick}) so the component relies on the consolidated CSS for the reset.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@apps/web-dashboard/src/components/AuthShell.jsx`:
- Around line 22-29: Move the inline button-reset styles out of the JSX and into
the CSS class: update the .auth-form-card__mode--clickable rule in your
stylesheet to include background: none, border: none, cursor: pointer, and
padding: 0, then remove the style prop from the button element in AuthShell.jsx
(the button that uses className "auth-form-card__mode
auth-form-card__mode--clickable" and onClick={onModeClick}) so the component
relies on the consolidated CSS for the reset.
In `@apps/web-dashboard/src/index.css`:
- Around line 869-873: The hover rule for .auth-form-card__mode--clickable:hover
redundantly reassigns background to var(--color-auth-mode-bg) which is already
set on .auth-form-card__mode; remove the background declaration from the :hover
block so the hover only changes color and text-decoration (leave
.auth-form-card__mode and .auth-form-card__mode--clickable:hover selectors
intact).
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: d51b61f5-dff0-4c3c-8543-121461ea44a1
📒 Files selected for processing (4)
apps/web-dashboard/src/components/AuthShell.jsxapps/web-dashboard/src/index.cssapps/web-dashboard/src/pages/Signup.jsxapps/web-dashboard/vite.config.js
|
Really thank for doing this again, appreciated. Can u please answer this that why theres changes in vite config file, if thats not necessary then please remove that. |
|
extra points for nice cooperation. Thank you. |
|
@yash-pouranik Thank you so much ! |
🚀 Pull Request Description
Fixes #228
🛠️ Type of Change
📋 Changes Made
🧪 Testing & Validation
Frontend Verification:
📸 Screenshots
✅ Checklist
💡 Benefits
Built with ❤️ for urBackend
Summary by CodeRabbit
New Features
Style