Skip to content

fix(dashboard-api): enforce SameSite=Lax on all cookies to prevent CSRF attacks #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yash-pouranik merged 1 commit into from
May 31, 2026
Merged

fix(dashboard-api): enforce SameSite=Lax on all cookies to prevent CSRF attacks #240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/dashboard-api/src/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ const csrfProtection = csurf({
cookie: {
httpOnly: true,
secure: process.env.NODE_ENV === 'production',
sameSite: process.env.NODE_ENV === 'production' ? 'none' : 'lax'
sameSite: 'lax'
}
});

Expand Down
14 changes: 7 additions & 7 deletions apps/dashboard-api/src/controllers/auth.controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ const getCookieOptions = () => {
httpOnly: true,
expires: new Date(Date.now() + 7 * 24 * 60 * 60 * 1000),
secure: process.env.NODE_ENV === 'production',
sameSite: process.env.NODE_ENV === 'production' ? 'none' : 'lax'
sameSite: 'lax'
};

if (process.env.NODE_ENV === 'production') {
Expand Down Expand Up @@ -83,7 +83,7 @@ const clearGithubStateCookie = (res) => {
res.cookie(GITHUB_STATE_COOKIE, 'none', {
httpOnly: true,
secure: process.env.NODE_ENV === 'production',
sameSite: process.env.NODE_ENV === 'production' ? 'none' : 'lax',
sameSite: 'lax',
expires: new Date(Date.now() + 10 * 1000),
});
};
Expand Down Expand Up @@ -354,7 +354,7 @@ module.exports.startGithubAuth = async (req, res) => {
res.cookie(GITHUB_STATE_COOKIE, state, {
httpOnly: true,
secure: process.env.NODE_ENV === 'production',
sameSite: process.env.NODE_ENV === 'production' ? 'none' : 'lax',
sameSite: 'lax',
expires: new Date(Date.now() + GITHUB_STATE_TTL_MS),
});

Expand Down Expand Up @@ -565,13 +565,13 @@ module.exports.resetPassword = async (req, res) => {
expires: new Date(Date.now() + 10 * 1000),
httpOnly: true,
secure: process.env.NODE_ENV === 'production',
sameSite: process.env.NODE_ENV === 'production' ? 'none' : 'lax'
sameSite: 'lax'
})
.cookie('refreshToken', 'none', {
expires: new Date(Date.now() + 10 * 1000),
httpOnly: true,
secure: process.env.NODE_ENV === 'production',
sameSite: process.env.NODE_ENV === 'production' ? 'none' : 'lax'
sameSite: 'lax'
})
.json({ message: "Password reset successfully. Please log in with your new password." });
} catch (err) {
Expand All @@ -597,13 +597,13 @@ module.exports.logout = async (req, res) => {
expires: new Date(Date.now() + 10 * 1000),
httpOnly: true,
secure: process.env.NODE_ENV === 'production',
sameSite: process.env.NODE_ENV === 'production' ? 'none' : 'lax'
sameSite: 'lax'
});
res.cookie('refreshToken', 'none', {
expires: new Date(Date.now() + 10 * 1000),
httpOnly: true,
secure: process.env.NODE_ENV === 'production',
sameSite: process.env.NODE_ENV === 'production' ? 'none' : 'lax'
sameSite: 'lax'
});

res.status(200).json({ success: true, message: "Logged out successfully" });
Expand Down
Loading