Skip to content

SDK-2771: Small fixes #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MrBurtyyy merged 2 commits into from
Dec 17, 2025
Merged

SDK-2771: Small fixes #509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f854895
SDK-2771: Read from the error stream if we get >= 400 HTTP status cod…
MrBurtyyy Dec 17, 2025
f36aabe
SDK-2771: Specify exact json property names for response from auth se…
MrBurtyyy Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions yoti-sdk-auth/src/main/java/com/yoti/auth/CreateAuthenticationTokenResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,19 @@
package com.yoti.auth;

import com.fasterxml.jackson.annotation.JsonProperty;

public final class CreateAuthenticationTokenResponse {

@JsonProperty("access_token")
Copy link
Copy Markdown
Collaborator

@bucky-boy bucky-boy Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please double check that we're doing this on every property of every payload

private String accessToken;

@JsonProperty("token_type")
private String tokenType;

@JsonProperty("expires_in")
private Integer expiresIn;

@JsonProperty("scope")
private String scope;

/**
Expand Down
8 changes: 4 additions & 4 deletions yoti-sdk-auth/src/main/java/com/yoti/auth/FormRequestClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,14 +59,14 @@ private static String encode(String v) {
private byte[] parseResponse(HttpURLConnection httpUrlConnection) throws ResourceException, IOException {
int responseCode = httpUrlConnection.getResponseCode();
if (responseCode >= HttpURLConnection.HTTP_BAD_REQUEST) {
byte[] responseBody = readBody(httpUrlConnection);
byte[] responseBody = readBody(httpUrlConnection.getErrorStream());
throw new ResourceException(responseCode, httpUrlConnection.getResponseMessage(), new String(responseBody));
}
return readBody(httpUrlConnection);
return readBody(httpUrlConnection.getInputStream());
}

private byte[] readBody(HttpURLConnection httpURLConnection) throws IOException {
try (QuietCloseable<InputStream> inputStream = new QuietCloseable<>(httpURLConnection.getInputStream())) {
private byte[] readBody(InputStream httpInputStream) throws IOException {
try (QuietCloseable<InputStream> inputStream = new QuietCloseable<>(httpInputStream)) {
return readChunked(inputStream.get());
}
}
Expand Down