Eslint 9 upgrade (#572)

* Updated to eslint 9+

* Removed linting from /examples (linted from the project root)

* Exclude eslint.config.mjs for SonarQube

Author: laurent-yoti

.eslintignore

@@ -33,8 +33,8 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
 
-  examples:
-    name: Lint Examples
+  lint:
+    name: Lint
     runs-on: ubuntu-latest
     if: >
       github.event_name == 'push' ||
@@ -45,7 +45,7 @@ jobs:
 
       - uses: actions/setup-node@v4
         with:
-          node-version: '16'
+          node-version: '20'
 
       - run: npm install --ignore-scripts
 
@@ -54,15 +54,22 @@ jobs:
       - name: print versions
         run: echo npm $(npm -v), node $(node -v)
 
-      - run: pushd ./examples/aml-check && npm install --ignore-scripts && npm update && npm run lint && popd
+      - run: npm install --ignore-scripts -p ./examples/aml-check
+      - run: npm install --ignore-scripts -p ./examples/digital-identity
+      - run: npm install --ignore-scripts -p ./examples/idv
+      - run: npm install --ignore-scripts -p ./examples/idv-identity-checks
+      - run: npm install --ignore-scripts -p ./examples/profile
+      - run: npm install --ignore-scripts -p ./examples/profile-identity-checks
 
-      - run: pushd ./examples/idv && npm install --ignore-scripts && npm update && npm run lint && popd
+      - run: npm run lint
 
-      - run: pushd ./examples/idv-identity-checks && npm install --ignore-scripts && npm update && npm run lint && popd
-
-      - run: pushd ./examples/profile && npm install --ignore-scripts && npm update && npm run lint && popd
-
-      - run: pushd ./examples/profile-identity-checks && npm install --ignore-scripts && npm update && npm run lint && popd
+#      - run: pushd ./examples/idv && npm install --ignore-scripts && npm update && npm run lint && popd
+#
+#      - run: pushd ./examples/idv-identity-checks && npm install --ignore-scripts && npm update && npm run lint && popd
+#
+#      - run: pushd ./examples/profile && npm install --ignore-scripts && npm update && npm run lint && popd
+#
+#      - run: pushd ./examples/profile-identity-checks && npm install --ignore-scripts && npm update && npm run lint && popd
 
   node-compatibility:
     name: Node ${{ matrix.node-version }}
@@ -89,7 +96,7 @@ jobs:
       - run: npm update
 
       # Jest 30 does not support Node 14/16
-      - run: npm install jest@29
+      - run: npm install --ignore-scripts jest@29
 
       - run: npm run test
 

.eslintrc.js

@@ -1,8 +1,5 @@
 {
     "moderate": true,
     "skip-dev": false,
-    "allowlist": [
-        "GHSA-p5wg-g6qr-c7cg|eslint",
-        "GHSA-p5wg-g6qr-c7cg|eslint-config-airbnb-base>eslint"
-    ]
+    "allowlist": []
 }

.github/workflows/tests.yaml

@@ -0,0 +1,83 @@
+import path from 'path';
+
+import { includeIgnoreFile } from '@eslint/compat';
+import js from '@eslint/js';
+import { defineConfig } from 'eslint/config';
+import { configs, plugins } from 'eslint-config-airbnb-extended';
+import pluginJest from 'eslint-plugin-jest';
+
+const gitignorePath = path.resolve('.', '.gitignore');
+const gitIgnored = includeIgnoreFile(gitignorePath);
+
+const jsConfig = defineConfig([
+  // ESLint recommended config
+  {
+    name: 'js/config',
+    ...js.configs.recommended,
+  },
+  // Stylistic plugin
+  plugins.stylistic,
+  // Import X plugin
+  plugins.importX,
+  // Airbnb base recommended config
+  ...configs.base.recommended,
+]);
+
+const nodeConfig = defineConfig([
+  // Node plugin
+  plugins.node,
+  // Airbnb Node recommended config
+  ...configs.node.recommended,
+]);
+
+const fullConfig = defineConfig([
+  {
+    ignores: [...gitIgnored.ignores, 'types'],
+  },
+  // JavaScript config
+  ...jsConfig,
+  // Node config
+  ...nodeConfig,
+  {
+    files: ['**/*.spec.js'],
+    plugins: { jest: pluginJest },
+    languageOptions: {
+      globals: pluginJest.environments.globals.globals,
+    },
+    rules: {
+      'jest/no-disabled-tests': 'warn',
+      'jest/no-focused-tests': 'error',
+      'jest/no-identical-title': 'error',
+      'jest/prefer-to-have-length': 'warn',
+      'jest/valid-expect': 'error',
+    },
+  },
+  {
+    rules: {
+      'n/no-sync': 'off',
+      strict: 'off',
+      'default-param-last': 'off',
+      'prefer-object-spread': 'off',
+      '@stylistic/comma-dangle': ['error', {
+        arrays: 'always-multiline',
+        exports: 'always-multiline',
+        functions: 'never',
+        imports: 'always-multiline',
+        objects: 'always-multiline',
+      }],
+      '@stylistic/max-len': ['error', {
+        code: 160,
+        tabWidth: 2,
+        ignoreUrls: true,
+        ignoreComments: false,
+        ignoreRegExpLiterals: true,
+        ignoreStrings: true,
+        ignoreTemplateLiterals: true,
+        ignorePattern: '\\* @typedef \\{import',
+      }],
+      '@stylistic/brace-style': ['error', '1tbs', { allowSingleLine: true }],
+    },
+  },
+]);
+
+export default fullConfig;