Address Copilot review feedback on PageResponse

mehmet-yoti · mehmet-yoti · commit 024eafb3d5b8 · 2026-05-05T08:54:21.000+01:00
diff --git a/src/DocScan/Session/Retrieve/PageResponse.php b/src/DocScan/Session/Retrieve/PageResponse.php
@@ -44,7 +44,9 @@ public function __construct(array $page)
             }
         }
 
-        $this->extractionImageIds = $page['extraction_image_ids'] ?? [];
+        $this->extractionImageIds = isset($page['extraction_image_ids']) && is_array($page['extraction_image_ids'])
+            ? $page['extraction_image_ids']
+            : [];
     }
 
     /**
diff --git a/tests/DocScan/Session/Retrieve/PageResponseTest.php b/tests/DocScan/Session/Retrieve/PageResponseTest.php
@@ -53,7 +53,7 @@ public function testGetFrames()
         ]);
 
         $this->assertCount(2, $pageResponse->getFrames());
-        $this->containsOnlyInstancesOf(FrameResponse::class, $pageResponse->getFrames());
+        $this->assertContainsOnlyInstancesOf(FrameResponse::class, $pageResponse->getFrames());
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,9 @@ public function __construct(array $page)`
`44`	`44`	`}`
`45`	`45`	`}`
`46`	`46`
`47`		`- $this->extractionImageIds = $page['extraction_image_ids'] ?? [];`
	`47`	`+ $this->extractionImageIds = isset($page['extraction_image_ids']) && is_array($page['extraction_image_ids'])`
	`48`	`+ ? $page['extraction_image_ids']`
	`49`	`+ : [];`
`48`	`50`	`}`
`49`	`51`
`50`	`52`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ public function testGetFrames()`
`53`	`53`	`]);`
`54`	`54`
`55`	`55`	`$this->assertCount(2, $pageResponse->getFrames());`
`56`		`- $this->containsOnlyInstancesOf(FrameResponse::class, $pageResponse->getFrames());`
	`56`	`+ $this->assertContainsOnlyInstancesOf(FrameResponse::class, $pageResponse->getFrames());`
`57`	`57`	`}`
`58`	`58`
`59`	`59`	`/**`