refactor: remove duplicate searchable prop from Properties type#27
Closed
gfargo wants to merge 1 commit into
Closed
refactor: remove duplicate searchable prop from Properties type#27gfargo wants to merge 1 commit into
gfargo wants to merge 1 commit into
Conversation
Properties<V> extends UseEnhancedSelectInputProperties<V> which already declares searchable. The duplicate declaration in Properties was redundant. Now the component reads searchable from hookProperties directly.
Owner
Author
|
Superseded by #30 which consolidates all pre-1.0 polish work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove duplicate searchable prop declaration from Properties. It already inherits from UseEnhancedSelectInputProperties. No behavior change — 128 tests pass.