Pre-1.0.0 polish: refactors, bug fix, storybook, and test coverage#30
Merged
Conversation
- Properties<V> already inherits searchable from UseEnhancedSelectInputProperties<V> - Remove redundant declaration in Properties - Component now reads searchable from hookProperties directly - Remove default export (only named export is re-exported from package entry)
- Add 'exports' map with types and import conditions for modern ESM resolution - Add 'types' field pointing to dist/index.d.ts - Fix tsconfig target comment: was 'Node.js 14', now 'Node.js 20+'
Add demos for item groups, multi-select, searchable mode, and scroll indicators. The main menu now uses groups itself to categorize demos into 'Classic' and 'New in 1.0' sections.
…e tests The backspace handler only checked key.backspace, but terminals send \x7f (DEL) which Ink maps to key.delete, not key.backspace. Now checks both key.backspace and key.delete. New tests (5): - searchable + multiple: filter then confirm checked items - searchable + limit: navigation within paginated filtered results - searchable + isFocused=false: typing blocked - searchable: Home/End on filtered results - searchable: backspace progressively widens filter results
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-1.0.0 Polish
Consolidated PR with all pre-release fixes, organized as separate commits:
Commits
refactor: remove duplicate searchable prop and default export
Properties<V>already inheritssearchablefrom hook props — removed redundant declarationchore: add exports field to package.json, fix tsconfig comment
exportsmap with types-first resolutiontypesfieldchore: update storybook to demo all features
fix: handle key.delete for backspace in searchable mode
\x7f(DEL) for backspace, which Ink maps tokey.deletenotkey.backspacekey.backspace || key.deletedocs: add blog post outline for 1.0.0 release
Testing
Supersedes PRs #27, #28, #29 (can be closed).