Lock rank cleanup, part 1#9524
Open
andyleiserson wants to merge 4 commits into
Open
Conversation
* Groups the graph nodes by non-leaf, connected leaf, and disconnected leaf, instead of only by leaf and non-leaf. * List followers in the same order as the ranks themselves. * Don't print the acquisition locations by default. This makes the output closer to what appears in `rank.rs`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress towards #5937.
Does the following, in separate commits for each top-level bullet:
rank.rs.COMMAND_BUFFER_DATAis just protecting the command buffer mutable state. It is acquired just before encoding commands to move the mutable state out of the lock-protected location entirely. Once that is done, the mutable state only holds the emptyCommandEncoderStatus::Consumedsentinel. There aren't any hazards between the sentinel and the encoding process itself.)Testing
It is hard to use the lock validation build incrementally for each of the changes, but at the tip of my branch, the lock validation build can pass our test suite (including the enabled CTS tests).
Squash or Rebase? Rebase
Checklist
wgpumay be affected behaviorally.CHANGELOG.mdentries for the user-facing effects of this change are present.