server: add null check for context to prevent segfault on init failure#21477
Open
Anirudh171202 wants to merge 1 commit into
Open
server: add null check for context to prevent segfault on init failure#21477Anirudh171202 wants to merge 1 commit into
Anirudh171202 wants to merge 1 commit into
Conversation
ggerganov
approved these changes
Apr 6, 2026
dcb382c to
874fd89
Compare
Author
|
@ngxson could you take a quick look? It's a 5 line null check... ggerganov already approved, just needs a second review to unblock the merge approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a segfault when llama_context creation fails.
In
server-context.cpp::load_model, the return fromcommon_init_from_paramsis checked for a null model but not a null context. When context creation fails,llama_n_ctx(ctx)dereferences null and crashes.This adds a null check for ctx matching the existing model check.
Ref: #21450
Reproduction Steps:
On Apple Silicon,
It segfaulted before. Now it clean exits with an error message.
Also verified
--cache-type-k q4_0 --cache-type-v q4_0still works normally.Requirements