Skip to content

vendor : update cpp-httplib to 0.44.0#22919

Merged
CISC merged 1 commit intoggml-org:masterfrom
cabelo:cpp-httplib-0.44.0
May 11, 2026
Merged

vendor : update cpp-httplib to 0.44.0#22919
CISC merged 1 commit intoggml-org:masterfrom
cabelo:cpp-httplib-0.44.0

Conversation

@cabelo
Copy link
Copy Markdown
Contributor

@cabelo cabelo commented May 10, 2026

Overview

Additional information

Requirements

What's Changed

v0.44.0

Breaking change (behavioral)

  • Stop percent-decoding HTTP request header values. parse_header() previously applied decode_path_component() to every header value (except Location / Referer) after is_field_value() validation, so wire sequences like %0D%0A passed validation and expanded into literal CR/LF inside stored values — enabling response splitting, log injection, and proxy smuggling. %3D / %2C / %3B likewise flipped Cookie and X-Forwarded-For boundaries against WAFs inspecting the wire form. RFC 9110 §5.5 specifies header values as opaque octets, so the auto-decode (and the Location / Referer workarounds for the same misbehavior) has been removed. Applications that need URI semantics on a header value should now call decode_uri_component() or decode_path_component() on the result explicitly. Fixes the long-standing Referer-with-%0A issue

Bug fixes

  • Make ThreadPool constructor exception-safe on partial thread creation. If std::thread construction throws partway through (e.g. pthread_create returns EAGAIN under thread-resource pressure), the partially-built threads_ vector would destruct joinable std::thread objects and call std::terminate(). The spawn loop now signals shutdown to the workers already created, joins them, and rethrows.

Tooling

  • scripts/release.sh gains a --minor flag to force a minor bump even when abidiff reports no ABI break, for behavioral breaking changes like the header-decoding fix above (e8e6528)

@cabelo cabelo requested a review from ggerganov as a code owner May 10, 2026 19:19
@github-actions github-actions Bot added script Script related python python script changes labels May 10, 2026
@taronaeo taronaeo added the merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge. label May 11, 2026
@taronaeo taronaeo requested a review from a team May 11, 2026 01:45
@CISC CISC merged commit 8383743 into ggml-org:master May 11, 2026
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge. python python script changes script Script related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants