Skip to content

server: (router) fix stopping_thread potentially hang#24728

Merged
ngxson merged 2 commits into
ggml-org:masterfrom
ngxson:xsn/fix_child_proc_stop
Jun 18, 2026
Merged

server: (router) fix stopping_thread potentially hang#24728
ngxson merged 2 commits into
ggml-org:masterfrom
ngxson:xsn/fix_child_proc_stop

Conversation

@ngxson

@ngxson ngxson commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Overview

Adapt #22452 on top of #23976

  • Using subproc->stopped atomic bool that is shared between "loaded" and "downloading" states
  • Add wrapper subproc->terminate() to avoid patching vendor's source code

Requirements

@ngxson ngxson requested a review from a team as a code owner June 17, 2026 16:11
@ngxson ngxson merged commit fe7c8b2 into ggml-org:master Jun 18, 2026
23 of 25 checks passed
papamoose pushed a commit to papamoose/llama.cpp that referenced this pull request Jun 27, 2026
* server: (router) fix stopping_thread potentially hang

* fix windows build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant