examples : remove unused code from common.{cpp,h}#3244
Closed
danbev wants to merge 7 commits into
Closed
Conversation
This commit removes unused structs and functions from common.h and common.cpp. The motivation for this change to clean up the examples codebase and this is a start to that process. I was going to add VAD support to the server and actually thought of adding these params to common.h which is why I started looking at this.
Member
|
Should also stop syncing these sources from the
And would need a similar change in the |
danbev
added a commit
to danbev/ggml
that referenced
this pull request
Jun 12, 2025
danbev
added a commit
to danbev/ggml
that referenced
this pull request
Jun 12, 2025
This commit removes the common.{cpp,h} files from the whisper sync
scripts.
Refs: ggml-org/whisper.cpp#3244 (comment)
danbev
added a commit
to ggml-org/ggml
that referenced
this pull request
Jun 12, 2025
This commit removes the common.{cpp,h} files from the whisper sync
scripts.
Refs: ggml-org/whisper.cpp#3244 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes unused structs and functions from common.h and common.cpp.
The motivation for this change to clean up the examples codebase and this is a start to that process. I was going to add VAD support to the server and actually thought of adding these params to common.h which is why I started looking at this.