Skip to content

fix(coreml): remove broken --optimize-ane flag from generate script #3632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlanConstantino wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(coreml): remove broken --optimize-ane flag from generate script #3632

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion models/generate-coreml-model.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,10 @@ if [ "$mname" = "-h5" ]; then
echo "$mpath"
python3 models/convert-h5-to-coreml.py --model-name "$mname" --model-path "$mpath" --encoder-only True
else
python3 models/convert-whisper-to-coreml.py --model "$mname" --encoder-only True --optimize-ane True
# Note: --optimize-ane is disabled as it produces models that crash during inference.
# The ANE optimization code needs maintenance to work with newer model architectures
# and coremltools versions. See convert-whisper-to-coreml.py for details.
python3 models/convert-whisper-to-coreml.py --model "$mname" --encoder-only True
fi

xcrun coremlc compile models/coreml-encoder-"${mname}".mlpackage models/
Expand Down