Skip to content

Fix pkgconfig configuration (Nix build failure)#3894

Merged
danbev merged 1 commit into
ggml-org:masterfrom
nmouha:pkgconfig-full-libdir
Jun 23, 2026
Merged

Fix pkgconfig configuration (Nix build failure)#3894
danbev merged 1 commit into
ggml-org:masterfrom
nmouha:pkgconfig-full-libdir

Conversation

@nmouha

@nmouha nmouha commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

@danbev, @waptaff: PR #3693 leads to a build failure on Nix, where @CMAKE_INSTALL_LIBDIR@ is an absolute instead of a relative path. This leads to a malformed .pc file containing //.

For a correct, portable solution, @CMAKE_INSTALL_FULL_LIBDIR@ should be used instead.

This may impact other installations as well, and it would be better to fix this upstream rather than downstream: NixOS/nixpkgs#532522

@nmouha nmouha force-pushed the pkgconfig-full-libdir branch 2 times, most recently from 6b14ea5 to 676c7b2 Compare June 22, 2026 01:16
Comment thread cmake/parakeet.pc.in Outdated
@nmouha nmouha force-pushed the pkgconfig-full-libdir branch from 676c7b2 to a706527 Compare June 22, 2026 15:38
@nmouha nmouha force-pushed the pkgconfig-full-libdir branch from a706527 to 7de3d29 Compare June 22, 2026 15:53
@danbev danbev merged commit bae6bc0 into ggml-org:master Jun 23, 2026
40 checks passed
@danbev

danbev commented Jun 23, 2026

Copy link
Copy Markdown
Member

@nmouha Thanks!

@nmouha

nmouha commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

Thank you, @danbev!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants