Fix pkgconfig configuration (Nix build failure)#3894
Merged
Conversation
6b14ea5 to
676c7b2
Compare
danbev
approved these changes
Jun 22, 2026
676c7b2 to
a706527
Compare
a706527 to
7de3d29
Compare
Member
|
@nmouha Thanks! |
Contributor
Author
|
Thank you, @danbev! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@danbev, @waptaff: PR #3693 leads to a build failure on Nix, where
@CMAKE_INSTALL_LIBDIR@is an absolute instead of a relative path. This leads to a malformed .pc file containing//.For a correct, portable solution,
@CMAKE_INSTALL_FULL_LIBDIR@should be used instead.This may impact other installations as well, and it would be better to fix this upstream rather than downstream: NixOS/nixpkgs#532522