Skip to content

feat: inline ZipOptions interface to drop fflate dep in types pkg#193

Merged
ghiscoding merged 1 commit into
mainfrom
refactor/inline-zip-options
Jun 12, 2026
Merged

feat: inline ZipOptions interface to drop fflate dep in types pkg#193
ghiscoding merged 1 commit into
mainfrom
refactor/inline-zip-options

Conversation

@ghiscoding

Copy link
Copy Markdown
Owner

by looking at dependencies via node-module-inspector, I found out that @excel-builder-vanilla/types requires fflate as dependency but we don't really that since it's just a small list of options that we can easily inlined as interface and just drop fflate dep

@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.9%. Comparing base (641cc60) to head (810ca75).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #193   +/-   ##
=====================================
  Coverage   99.9%   99.9%           
=====================================
  Files         25      25           
  Lines       1803    1803           
  Branches     349     349           
=====================================
  Hits        1801    1801           
  Misses         2       2           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ghiscoding ghiscoding merged commit 1c99f99 into main Jun 12, 2026
5 checks passed
@ghiscoding ghiscoding deleted the refactor/inline-zip-options branch June 12, 2026 23:03
@github-actions

Copy link
Copy Markdown

🎉 This pull request is included in version 5.1.0 📦
🔗 The release notes are available at: GitHub Release 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant