Skip to content

Commit 10f7f5e

Browse files
authored
chore(deps): fix failing unit tests with Vitest@3.2.1 & other catalog (#1999)
1 parent f3e5866 commit 10f7f5e

8 files changed

Lines changed: 226 additions & 472 deletions

File tree

demos/react/package.json

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@
6565
"react": "^19.1.0",
6666
"react-dom": "^19.1.0",
6767
"react-i18next": "^15.5.2",
68+
"react-router-dom": "^7.6.2",
6869
"slickgrid-react": "workspace:*"
6970
},
7071
"peerDependencies": {
@@ -81,17 +82,14 @@
8182
"@types/react": "^19.1.6",
8283
"@types/react-dom": "^19.1.5",
8384
"@types/sortablejs": "catalog:",
84-
"@types/text-encoding-utf-8": "^1.0.5",
8585
"@vitejs/plugin-react": "^4.5.1",
8686
"cross-env": "catalog:",
8787
"globals": "catalog:",
88-
"react-router-dom": "^7.6.1",
8988
"regenerator-runtime": "^0.14.1",
9089
"rxjs": "catalog:",
9190
"sass": "catalog:",
9291
"typescript": "catalog:",
9392
"vite": "catalog:",
94-
"vite-plugin-svgr": "^4.3.0",
95-
"vite-tsconfig-paths": "^5.1.4"
93+
"vite-tsconfig-paths": "catalog:"
9694
}
9795
}

frameworks/angular-slickgrid/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@
131131
"typescript": "~5.8.3",
132132
"typescript-eslint": "^8.33.1",
133133
"vite": "catalog:",
134-
"vite-tsconfig-paths": "^5.1.4",
134+
"vite-tsconfig-paths": "catalog:",
135135
"vitest": "catalog:",
136136
"zone.js": "~0.15.1"
137137
}

frameworks/slickgrid-react/package.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -101,14 +101,13 @@
101101
"native-copyfiles": "catalog:",
102102
"react": "^19.1.0",
103103
"react-dom": "^19.1.0",
104-
"react-router-dom": "^7.6.1",
104+
"react-router-dom": "^7.6.2",
105105
"regenerator-runtime": "^0.14.1",
106106
"rimraf": "catalog:",
107107
"rxjs": "catalog:",
108108
"sass": "catalog:",
109109
"typescript": "catalog:",
110110
"vite": "catalog:",
111-
"vite-plugin-svgr": "^4.3.0",
112-
"vite-tsconfig-paths": "^5.1.4"
111+
"vite-tsconfig-paths": "catalog:"
113112
}
114113
}

packages/common/src/services/__tests__/extension.service.spec.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -739,15 +739,13 @@ describe('ExtensionService', () => {
739739
const cellMenuSpy = vi.spyOn(service, 'translateCellMenu');
740740
const contextMenuSpy = vi.spyOn(service, 'translateContextMenu');
741741
const colHeaderSpy = vi.spyOn(service, 'translateColumnHeaders');
742-
const contextSpy = vi.spyOn(service, 'translateContextMenu');
743742
const headerMenuSpy = vi.spyOn(service, 'translateHeaderMenu');
744743

745744
service.translateAllExtensions();
746745

747746
expect(cellMenuSpy).toHaveBeenCalled();
748747
expect(contextMenuSpy).toHaveBeenCalled();
749748
expect(colHeaderSpy).toHaveBeenCalled();
750-
expect(contextSpy).toHaveBeenCalled();
751749
expect(headerMenuSpy).toHaveBeenCalled();
752750
});
753751

packages/common/src/services/__tests__/grid.service.spec.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1792,7 +1792,6 @@ describe('Grid Service', () => {
17921792
const autoSizeSpy = vi.spyOn(gridStub, 'autosizeColumns');
17931793
const setColsSpy = vi.spyOn(gridStub, 'setColumns');
17941794
const pubSubSpy = vi.spyOn(pubSubServiceStub, 'publish');
1795-
const setColSpy = vi.spyOn(gridStub, 'setColumns');
17961795

17971796
const output = service.hideColumnById('field2');
17981797

@@ -1801,7 +1800,6 @@ describe('Grid Service', () => {
18011800
expect(setVisibleSpy).toHaveBeenCalledWith(mockWithoutColumns);
18021801
expect(setColsSpy).toHaveBeenCalledWith(mockWithoutColumns);
18031802
expect(pubSubSpy).toHaveBeenCalledWith('onHideColumns', { columns: mockWithoutColumns });
1804-
expect(setColSpy).toHaveBeenCalledTimes(1);
18051803
});
18061804

18071805
it('should set new columns minus the column to hide but without triggering an event when set to False', () => {

packages/row-detail-view-plugin/src/slickRowDetailView.spec.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1046,8 +1046,6 @@ describe('SlickRowDetailView plugin', () => {
10461046
gridStub.onScroll.notify({ scrollLeft: 20, scrollTop: 53, scrollHeight: 10, grid: gridStub }, eventData as any, gridStub);
10471047
vi.advanceTimersByTime(1);
10481048

1049-
expect(onRowOutOfViewportSpy).toHaveBeenCalled();
1050-
10511049
vi.spyOn(gridStub, 'getRenderedRange').mockReturnValue({ top: 125, bottom: 150, left: 33, right: 18 } as any);
10521050
plugin.expandDetailView(123);
10531051
plugin.addonOptions.singleRowExpand = false;

0 commit comments

Comments
 (0)