chore: update npm release CI workflow

Author: ghiscoding

.github/workflows/publish-npm-prerelease.yml

@@ -173,18 +173,26 @@ jobs:
         shell: bash
         id: lerna-publish
         run: |
-          # Attempt to publish all packages
-          pnpm exec lerna publish from-package --force-publish --dist-tag ${{ inputs.tag }} --yes --otp ${{ steps.wait-for-secrets.outputs.OTP }}
-          EXIT_CODE=$?
-          echo "EXIT_CODE=$EXIT_CODE" >> $GITHUB_ENV
-          OUTPUT=$(cat /dev/stdout)
-          echo "OUTPUT=$OUTPUT" >> $GITHUB_ENV
+          set -o pipefail
+          OUTPUT_FILE=$(mktemp)
+          pnpm exec lerna publish from-package --force-publish --dist-tag ${{ inputs.tag }} --yes --otp ${{ steps.wait-for-secrets.outputs.OTP }} 2>&1 | tee $OUTPUT_FILE
+          EXIT_CODE=${PIPESTATUS[0]}
+          OUTPUT=$(cat $OUTPUT_FILE)
+          echo "publish_failed=false" >> $GITHUB_OUTPUT
+          echo "publish_output<<EOF" >> $GITHUB_OUTPUT
+          echo "$OUTPUT" >> $GITHUB_OUTPUT
+          echo "EOF" >> $GITHUB_OUTPUT
           if [ $EXIT_CODE -ne 0 ]; then
-            echo "::set-output name=publish_failed::true"
+            if echo "$OUTPUT" | grep -q 'HttpErrorAuthOTP'; then
+              echo "publish_failed=true" >> $GITHUB_OUTPUT
+            else
+              echo "::error title=Lerna Publish Failed::$OUTPUT"
+              exit $EXIT_CODE
+            fi
           fi
 
       - name: Check for EOTP and Prompt for New OTP
-        if: ${{ steps.lerna-publish.outputs.publish_failed == 'true' && contains(env.OUTPUT, 'HttpErrorAuthOTP') }}
+        if: ${{ steps.lerna-publish.outputs.publish_failed == 'true' }}
         uses: step-security/wait-for-secrets@v1
         id: wait-for-new-otp
         with:
@@ -194,14 +202,13 @@ jobs:
               description: 'OTP from authenticator app'
 
       - name: Retry Lerna Publish with New OTP
-        if: ${{ steps.lerna-publish.outputs.publish_failed == 'true' && contains(env.OUTPUT, 'HttpErrorAuthOTP') }}
+        if: ${{ steps.lerna-publish.outputs.publish_failed == 'true' }}
         env:
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
           NPM_CONFIG_PROVENANCE: true
         shell: bash
         run: |
-          # Retry the publish command with the new OTP
           pnpm exec lerna publish from-package --force-publish --dist-tag ${{ inputs.tag }} --yes --otp ${{ steps.wait-for-new-otp.outputs.OTP }} || {
             echo "::error title=Publish Failed::Publishing failed even after providing a new OTP."
             exit 1

.github/workflows/publish-npm-prompt.yml

@@ -124,18 +124,26 @@ jobs:
         shell: bash
         id: lerna-publish
         run: |
-          # Attempt to publish all packages
-          pnpm exec lerna publish from-package --force-publish --yes --otp ${{ steps.wait-for-secrets.outputs.OTP }}
-          EXIT_CODE=$?
-          echo "EXIT_CODE=$EXIT_CODE" >> $GITHUB_ENV
-          OUTPUT=$(cat /dev/stdout)
-          echo "OUTPUT=$OUTPUT" >> $GITHUB_ENV
+          set -o pipefail
+          OUTPUT_FILE=$(mktemp)
+          pnpm exec lerna publish from-package --force-publish --yes --otp ${{ steps.wait-for-secrets.outputs.OTP }} 2>&1 | tee $OUTPUT_FILE
+          EXIT_CODE=${PIPESTATUS[0]}
+          OUTPUT=$(cat $OUTPUT_FILE)
+          echo "publish_failed=false" >> $GITHUB_OUTPUT
+          echo "publish_output<<EOF" >> $GITHUB_OUTPUT
+          echo "$OUTPUT" >> $GITHUB_OUTPUT
+          echo "EOF" >> $GITHUB_OUTPUT
           if [ $EXIT_CODE -ne 0 ]; then
-            echo "::set-output name=publish_failed::true"
+            if echo "$OUTPUT" | grep -q 'HttpErrorAuthOTP'; then
+              echo "publish_failed=true" >> $GITHUB_OUTPUT
+            else
+              echo "::error title=Lerna Publish Failed::$OUTPUT"
+              exit $EXIT_CODE
+            fi
           fi
 
       - name: Check for EOTP and Prompt for New OTP
-        if: ${{ steps.lerna-publish.outputs.publish_failed == 'true' && contains(env.OUTPUT, 'HttpErrorAuthOTP') }}
+        if: ${{ steps.lerna-publish.outputs.publish_failed == 'true' }}
         uses: step-security/wait-for-secrets@v1
         id: wait-for-new-otp
         with:
@@ -145,14 +153,13 @@ jobs:
               description: 'OTP from authenticator app'
 
       - name: Retry Lerna Publish with New OTP
-        if: ${{ steps.lerna-publish.outputs.publish_failed == 'true' && contains(env.OUTPUT, 'HttpErrorAuthOTP') }}
+        if: ${{ steps.lerna-publish.outputs.publish_failed == 'true' }}
         env:
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
           NPM_CONFIG_PROVENANCE: true
         shell: bash
         run: |
-          # Retry the publish command with the new OTP
           pnpm exec lerna publish from-package --force-publish --yes --otp ${{ steps.wait-for-new-otp.outputs.OTP }} || {
             echo "::error title=Publish Failed::Publishing failed even after providing a new OTP."
             exit 1

.github/workflows/publish-npm-publish-retry.yml

@@ -69,6 +69,15 @@ jobs:
       - name: Build Everything
         run: pnpm build
 
+      # because ng-packagr copies the package.json to dist,
+      # we need to re-run the build to get latest version in its dist/package.json
+      - name: run another Angular-Slickgrid build
+        run: pnpm run angular:build:framework
+
+      # then we need to replace all `workspace:` protocol with valid workspace package versions
+      - name: replace Angular-Slickgrid "workspace:"
+        run: pnpm run angular:replace-workspace
+
       - name: OTP
         if: ${{ inputs.dryrun != true }}
         uses: step-security/wait-for-secrets@v1