fix(angular): Angular-Slickgrid npm publish should replace workspace:

Author: ghiscoding

.github/workflows/publish-npm-latest.yml

@@ -128,18 +128,26 @@ jobs:
         shell: bash
         id: lerna-publish
         run: |
-          # Attempt to publish all packages
-          pnpm exec lerna publish from-package --force-publish --yes --otp ${{ steps.wait-for-secrets.outputs.OTP }}
-          EXIT_CODE=$?
-          echo "EXIT_CODE=$EXIT_CODE" >> $GITHUB_ENV
-          OUTPUT=$(cat /dev/stdout)
-          echo "OUTPUT=$OUTPUT" >> $GITHUB_ENV
+          set -o pipefail
+          OUTPUT_FILE=$(mktemp)
+          pnpm exec lerna publish from-package --force-publish --yes --otp ${{ steps.wait-for-secrets.outputs.OTP }} 2>&1 | tee $OUTPUT_FILE
+          EXIT_CODE=${PIPESTATUS[0]}
+          OUTPUT=$(cat $OUTPUT_FILE)
+          echo "publish_failed=false" >> $GITHUB_OUTPUT
+          echo "publish_output<<EOF" >> $GITHUB_OUTPUT
+          echo "$OUTPUT" >> $GITHUB_OUTPUT
+          echo "EOF" >> $GITHUB_OUTPUT
           if [ $EXIT_CODE -ne 0 ]; then
-            echo "::set-output name=publish_failed::true"
+            if echo "$OUTPUT" | grep -q 'HttpErrorAuthOTP'; then
+              echo "publish_failed=true" >> $GITHUB_OUTPUT
+            else
+              echo "::error title=Lerna Publish Failed::$OUTPUT"
+              exit $EXIT_CODE
+            fi
           fi
 
       - name: Check for EOTP and Prompt for New OTP
-        if: ${{ steps.lerna-publish.outputs.publish_failed == 'true' && contains(env.OUTPUT, 'HttpErrorAuthOTP') }}
+        if: ${{ steps.lerna-publish.outputs.publish_failed == 'true' }}
         uses: step-security/wait-for-secrets@v1
         id: wait-for-new-otp
         with:
@@ -149,14 +157,13 @@ jobs:
               description: 'OTP from authenticator app'
 
       - name: Retry Lerna Publish with New OTP
-        if: ${{ steps.lerna-publish.outputs.publish_failed == 'true' && contains(env.OUTPUT, 'HttpErrorAuthOTP') }}
+        if: ${{ steps.lerna-publish.outputs.publish_failed == 'true' }}
         env:
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
           NPM_CONFIG_PROVENANCE: true
         shell: bash
         run: |
-          # Retry the publish command with the new OTP
           pnpm exec lerna publish from-package --force-publish --yes --otp ${{ steps.wait-for-new-otp.outputs.OTP }} || {
             echo "::error title=Publish Failed::Publishing failed even after providing a new OTP."
             exit 1

frameworks/angular-slickgrid/scripts/replace-workspace.mjs

@@ -12,16 +12,18 @@ const projectRootPath = pJoin(__dirname, '../');
  * with current version from "package.json" root into "dist/package.json"
  */
 (async function main() {
-  const rootPkg = readJSONSync(pJoin(projectRootPath, 'package.json'));
   const distPkg = readJSONSync(pJoin(projectRootPath, 'dist', 'package.json'));
-  const currentVersion = rootPkg.version;
 
   // replace all workspace protocol with current version from "package.json" root into "dist/package.json"
   console.log('-------------------------------------------------------------------------------------');
-  console.log(`- Angular-Slickgrid, replace all "workspace:*" with "${currentVersion}" in "dist/package.json"`);
+  console.log(`Angular-Slickgrid, replace all "workspace:*" protocol in "dist/package.json"`);
   for (let [depName, depVersion] of Object.entries(distPkg.dependencies)) {
     if (depVersion.startsWith('workspace:*')) {
-      distPkg.dependencies[depName] = currentVersion;
+      // we need to get each package version
+      const depPkgName = depName.replace('@slickgrid-universal', '');
+      const depPkg = readJSONSync(pJoin(projectRootPath, '../../packages/', depPkgName, 'package.json'));
+      distPkg.dependencies[depName] = depPkg.version;
+      console.log(`replace "${depName}" dependency to "${depPkg.version}"`);
     }
   }
   writeJsonSync(pResolve(projectRootPath, 'dist', 'package.json'), distPkg, { spaces: 2 });