Skip to content

fix(core): small UI regression causing column width to be smaller#1973

Merged
ghiscoding merged 4 commits into
masterfrom
bugfix/grid-canvas-width
May 14, 2025
Merged

fix(core): small UI regression causing column width to be smaller#1973
ghiscoding merged 4 commits into
masterfrom
bugfix/grid-canvas-width

Conversation

@ghiscoding

@ghiscoding ghiscoding commented May 14, 2025

Copy link
Copy Markdown
Owner

trying again to fix the issue shown below, this issue is only happening in some Chromium browsers, it's rare but it does show then it shows consistently and it never happens in Firefox. I'm assuming this issue is caused by Chrome miscalculating the width (possibly because of float precision) and when that happens the scrollbar shows too early. In the case below, our grid container is 800px, we remove 15px for scrollbar and so we have 785px left for the columns and it's supposed to fit perfectly... but for some reasons, some browsers show the scrollbar when it shouldn't

image

@bolt-new-by-stackblitz

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@codecov

codecov Bot commented May 14, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.0%. Comparing base (4499f42) to head (5c19e86).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1973   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         195      195           
  Lines       35920    35920           
  Branches    10645    10647    +2     
=======================================
  Hits        35920    35920           
Flag Coverage Δ
angular 100.0% <ø> (ø)
universal 100.0% <100.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ghiscoding ghiscoding merged commit 8bf8c3e into master May 14, 2025
14 of 15 checks passed
@ghiscoding ghiscoding deleted the bugfix/grid-canvas-width branch May 14, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant