fix(core): small UI regression causing column width to be smaller#1973
Merged
Conversation
- partially rolling back a small change made in PR #1961
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1973 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 195 195
Lines 35920 35920
Branches 10645 10647 +2
=======================================
Hits 35920 35920
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Math.fround(float) instead ofMath.floor(int) for column width calculations, it helps with some grids but not all of themtrying again to fix the issue shown below, this issue is only happening in some Chromium browsers, it's rare but it does show then it shows consistently and it never happens in Firefox. I'm assuming this issue is caused by Chrome miscalculating the width (possibly because of float precision) and when that happens the scrollbar shows too early. In the case below, our grid container is 800px, we remove 15px for scrollbar and so we have 785px left for the columns and it's supposed to fit perfectly... but for some reasons, some browsers show the scrollbar when it shouldn't