Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions packages/common/src/core/__tests__/slickDataView.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,29 @@ describe('SlickDatView core file', () => {
expect(dv.getItems()).toEqual([{ id: 0, name: 'John', age: 20 }]);
expect(refreshSpy).toHaveBeenCalled();
});

test('delete multiple items with multi-digit indices in correct numeric order', () => {
const refreshSpy = vi.spyOn(dv, 'refresh');
const items = [
{ id: 0, name: 'Item0' },
{ id: 1, name: 'Item1' },
{ id: 2, name: 'Item2' },
{ id: 3, name: 'Item3' },
{ id: 10, name: 'Item10' },
{ id: 20, name: 'Item20' },
];

dv.setItems(items);
dv.deleteItems([20, 2, 10]); // Non-sequential, multi-digit indices

// Should delete items at indices 2, 10, 20 (Item2, Item10, Item20)
expect(dv.getItems()).toEqual([
{ id: 0, name: 'Item0' },
{ id: 1, name: 'Item1' },
{ id: 3, name: 'Item3' },
]);
expect(refreshSpy).toHaveBeenCalled();
});
});

describe('deleteItems()', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/common/src/core/slickDataview.ts
Original file line number Diff line number Diff line change
Expand Up @@ -751,7 +751,7 @@ export class SlickDataView<TData extends SlickDataItem = any> implements CustomD
}

// Remove from back to front
indexesToDelete.sort();
indexesToDelete.sort((a, b) => a - b);
for (let i = indexesToDelete.length - 1; i >= 0; --i) {
this.items.splice(indexesToDelete[i], 1);
}
Expand Down
Loading