Skip to content

refactor: move common editor code to BaseEditorClass#2595

Merged
ghiscoding merged 4 commits into
masterfrom
refactor/base-editor-class
May 24, 2026
Merged

refactor: move common editor code to BaseEditorClass#2595
ghiscoding merged 4 commits into
masterfrom
refactor/base-editor-class

Conversation

@ghiscoding

@ghiscoding ghiscoding commented May 24, 2026

Copy link
Copy Markdown
Owner

follow-up of previous Fallow suggestions

@codecov

codecov Bot commented May 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (db293cc) to head (1e8755d).

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #2595    +/-   ##
========================================
  Coverage   100.0%   100.0%            
========================================
  Files         198      199     +1     
  Lines       25312    25168   -144     
  Branches     8961     8908    -53     
========================================
- Hits        25312    25168   -144     
Flag Coverage Δ
angular 100.0% <ø> (ø)
universal 100.0% <100.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new

pkg-pr-new Bot commented May 24, 2026

Copy link
Copy Markdown
angular-slickgrid

npm i https://pkg.pr.new/angular-slickgrid@2595

aurelia-slickgrid

npm i https://pkg.pr.new/aurelia-slickgrid@2595

slickgrid-react

npm i https://pkg.pr.new/slickgrid-react@2595

slickgrid-vue

npm i https://pkg.pr.new/slickgrid-vue@2595

@slickgrid-universal/angular-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/angular-row-detail-plugin@2595

@slickgrid-universal/aurelia-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/aurelia-row-detail-plugin@2595

@slickgrid-universal/react-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/react-row-detail-plugin@2595

@slickgrid-universal/vue-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/vue-row-detail-plugin@2595

@slickgrid-universal/binding

npm i https://pkg.pr.new/@slickgrid-universal/binding@2595

@slickgrid-universal/common

npm i https://pkg.pr.new/@slickgrid-universal/common@2595

@slickgrid-universal/composite-editor-component

npm i https://pkg.pr.new/@slickgrid-universal/composite-editor-component@2595

@slickgrid-universal/custom-footer-component

npm i https://pkg.pr.new/@slickgrid-universal/custom-footer-component@2595

@slickgrid-universal/custom-tooltip-plugin

npm i https://pkg.pr.new/@slickgrid-universal/custom-tooltip-plugin@2595

@slickgrid-universal/empty-warning-component

npm i https://pkg.pr.new/@slickgrid-universal/empty-warning-component@2595

@slickgrid-universal/event-pub-sub

npm i https://pkg.pr.new/@slickgrid-universal/event-pub-sub@2595

@slickgrid-universal/excel-export

npm i https://pkg.pr.new/@slickgrid-universal/excel-export@2595

@slickgrid-universal/graphql

npm i https://pkg.pr.new/@slickgrid-universal/graphql@2595

@slickgrid-universal/odata

npm i https://pkg.pr.new/@slickgrid-universal/odata@2595

@slickgrid-universal/pagination-component

npm i https://pkg.pr.new/@slickgrid-universal/pagination-component@2595

@slickgrid-universal/pdf-export

npm i https://pkg.pr.new/@slickgrid-universal/pdf-export@2595

@slickgrid-universal/row-detail-view-plugin

npm i https://pkg.pr.new/@slickgrid-universal/row-detail-view-plugin@2595

@slickgrid-universal/rxjs-observable

npm i https://pkg.pr.new/@slickgrid-universal/rxjs-observable@2595

@slickgrid-universal/sql

npm i https://pkg.pr.new/@slickgrid-universal/sql@2595

@slickgrid-universal/text-export

npm i https://pkg.pr.new/@slickgrid-universal/text-export@2595

@slickgrid-universal/utils

npm i https://pkg.pr.new/@slickgrid-universal/utils@2595

@slickgrid-universal/vanilla-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-bundle@2595

@slickgrid-universal/vanilla-force-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-force-bundle@2595

commit: 1e8755d

@ghiscoding ghiscoding merged commit 32f4a0c into master May 24, 2026
13 checks passed
@ghiscoding ghiscoding deleted the refactor/base-editor-class branch May 24, 2026 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant