Skip to content

fix: updating columns should include internal plugin columns#2607

Open
ghiscoding wants to merge 8 commits into
masterfrom
bugfix/update-column-with-features
Open

fix: updating columns should include internal plugin columns#2607
ghiscoding wants to merge 8 commits into
masterfrom
bugfix/update-column-with-features

Conversation

@ghiscoding

@ghiscoding ghiscoding commented Jun 12, 2026

Copy link
Copy Markdown
Owner

fixes #2605

this fixes a very old behavior that the end user had to remember to use gridService.getAllColumnDefinitions(); to get feature (plugin) dynamically created columns (e.g. RowSelection / RowDetail columns). It would be better if the grid would just do it for you.. and that is what this PR does

This PR takes code that was duplicated in all frameworks and moves the code into the GridStateService, which is easier to maintain (DRY) and then reuse some other GridState code to resync dynamically created columns, so whenever the columns SETTER is called it will resync all columns and now also include/add all the internal columns

@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (6e771ca) to head (a13f811).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2607   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         199      199           
  Lines       25168    25154   -14     
  Branches     8908     8903    -5     
=======================================
- Hits        25168    25154   -14     
Flag Coverage Δ
angular 100.0% <100.0%> (ø)
universal 100.0% <100.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new

pkg-pr-new Bot commented Jun 12, 2026

Copy link
Copy Markdown
angular-slickgrid

npm i https://pkg.pr.new/angular-slickgrid@2607

aurelia-slickgrid

npm i https://pkg.pr.new/aurelia-slickgrid@2607

slickgrid-react

npm i https://pkg.pr.new/slickgrid-react@2607

slickgrid-vue

npm i https://pkg.pr.new/slickgrid-vue@2607

@slickgrid-universal/angular-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/angular-row-detail-plugin@2607

@slickgrid-universal/aurelia-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/aurelia-row-detail-plugin@2607

@slickgrid-universal/react-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/react-row-detail-plugin@2607

@slickgrid-universal/vue-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/vue-row-detail-plugin@2607

@slickgrid-universal/binding

npm i https://pkg.pr.new/@slickgrid-universal/binding@2607

@slickgrid-universal/common

npm i https://pkg.pr.new/@slickgrid-universal/common@2607

@slickgrid-universal/composite-editor-component

npm i https://pkg.pr.new/@slickgrid-universal/composite-editor-component@2607

@slickgrid-universal/custom-footer-component

npm i https://pkg.pr.new/@slickgrid-universal/custom-footer-component@2607

@slickgrid-universal/custom-tooltip-plugin

npm i https://pkg.pr.new/@slickgrid-universal/custom-tooltip-plugin@2607

@slickgrid-universal/empty-warning-component

npm i https://pkg.pr.new/@slickgrid-universal/empty-warning-component@2607

@slickgrid-universal/event-pub-sub

npm i https://pkg.pr.new/@slickgrid-universal/event-pub-sub@2607

@slickgrid-universal/excel-export

npm i https://pkg.pr.new/@slickgrid-universal/excel-export@2607

@slickgrid-universal/graphql

npm i https://pkg.pr.new/@slickgrid-universal/graphql@2607

@slickgrid-universal/odata

npm i https://pkg.pr.new/@slickgrid-universal/odata@2607

@slickgrid-universal/pagination-component

npm i https://pkg.pr.new/@slickgrid-universal/pagination-component@2607

@slickgrid-universal/pdf-export

npm i https://pkg.pr.new/@slickgrid-universal/pdf-export@2607

@slickgrid-universal/row-detail-view-plugin

npm i https://pkg.pr.new/@slickgrid-universal/row-detail-view-plugin@2607

@slickgrid-universal/rxjs-observable

npm i https://pkg.pr.new/@slickgrid-universal/rxjs-observable@2607

@slickgrid-universal/sql

npm i https://pkg.pr.new/@slickgrid-universal/sql@2607

@slickgrid-universal/text-export

npm i https://pkg.pr.new/@slickgrid-universal/text-export@2607

@slickgrid-universal/utils

npm i https://pkg.pr.new/@slickgrid-universal/utils@2607

@slickgrid-universal/vanilla-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-bundle@2607

@slickgrid-universal/vanilla-force-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-force-bundle@2607

commit: a13f811

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Checkbox Selector column disappears after changing the column list

1 participant