Merge pull request #33 from giginet/codex/fix-issue-31-and-improve-test-coverage

Fix case-sensitive path handling

Author: giginet

__test__/arch_detector.test.ts

@@ -12,7 +12,7 @@ describe('ArchDetector', () => {
   })
 
   it('should detect architectures from universal binary', async () => {
-    const mockOutput = `.build/apple/Products/Release/myexecutable: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit executable x86_64] [arm64:Mach-O 64-bit executable arm64]
+    const mockOutput = `.build/apple/Products/Release/myexecutable: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit executable x86_64] [arm64]
 .build/apple/Products/Release/myexecutable (for architecture x86_64):   Mach-O 64-bit executable x86_64
 .build/apple/Products/Release/myexecutable (for architecture arm64):    Mach-O 64-bit executable arm64`
 

__test__/executable_collector.test.ts

@@ -60,7 +60,7 @@ describe('ExecutableCollector', () => {
   })
 
   it('should collect executables from apple directory with multiple architectures', async () => {
-    const executablePath = '.build/apple/Products/release/myExecutable'
+    const executablePath = '.build/apple/Products/Release/myExecutable'
     const mockGlobber = new MockGlobber()
     mockGlobber.glob.mockImplementation(() => {
       return Promise.resolve([executablePath])
@@ -82,6 +82,23 @@ describe('ExecutableCollector', () => {
     )
   })
 
+  it('should capitalize configuration for apple directory', async () => {
+    const executablePath = '.build/apple/Products/Release/myExecutable'
+    const mockGlobber = new MockGlobber()
+    mockGlobber.glob.mockResolvedValue([executablePath])
+    glob.create.mockResolvedValue(mockGlobber)
+    jest
+      .spyOn(ArchDetector.prototype, 'detectArch')
+      .mockResolvedValue(['arm64'])
+
+    const collector = new ExecutableCollector('myExecutable')
+    await collector.collect('release')
+
+    expect(glob.create).toHaveBeenCalledWith(
+      expect.stringContaining('apple/Products/Release')
+    )
+  })
+
   it('should return empty array when no executables found', async () => {
     const mockGlobber = new MockGlobber()
     mockGlobber.glob.mockImplementation(() => {

dist/index.js

@@ -20,11 +20,12 @@ export class ArchDetector {
     // First line contains the summary with all architectures
     const firstLine = lines[0]
     if (firstLine.includes('Mach-O universal binary')) {
-      // Extract architectures from the first line, handling Linux format
-      const archMatches = firstLine.match(/\[(?:\\012- )?(\w+):/g)
+      // Extract architectures from the first line, handling cases like
+      // "[x86_64:Mach-O 64-bit executable x86_64]" or "[arm64]"
+      const archMatches = firstLine.match(/\[(?:\\012- )?(\w+)(?:[:\]])/g)
       if (archMatches) {
         archMatches.forEach((match) => {
-          const arch = match.match(/(?:\\012- )?(\w+):/)?.[1]
+          const arch = match.match(/\[(?:\\012- )?(\w+)(?:[:\]])/)?.[1]
           if (arch) {
             architectures.push(arch)
           }

dist/index.js.map

@@ -1,6 +1,7 @@
 {
   "$schema": "https://json.schemastore.org/tsconfig",
   "extends": "./tsconfig.base.json",
+
   "compilerOptions": {
     "module": "NodeNext",
     "moduleResolution": "NodeNext",